Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag rule and tag name should be updated #768

Open
Sven-TBD opened this issue Aug 5, 2024 · 8 comments
Open

Tag rule and tag name should be updated #768

Sven-TBD opened this issue Aug 5, 2024 · 8 comments
Assignees
Labels

Comments

@Sven-TBD
Copy link
Contributor

Sven-TBD commented Aug 5, 2024

Is your feature request related to a problem? Please describe.
Original Issue is #650 (about XUDT) and #647 (about NFT).

Describe the solution you'd like
There're two tasks here:

  1. Update the name of the tag, which happens on the front end.
  • Invalid -> Invalid name
  • Suspicious ->Suspicious name
  • Layer1 asset
  • Layer2 asset
  • Name Length Exceeded
  1. Update the rules of judging what tag an asset should own.
  • All Chinese charactors should not be marked as "Suspicious name" nor "Invalid name"
  • The asset whose name contains over 2 continuous blanks should be marked as "Suspicious name". if there's only one blank or the blanks are not continuous, then it should not be marked as "Suspicious name".
  • BTW, if the assets name ends with a blank, it should be marked as "Suspicious name"

Additional context

  • Related PRD link to the name and description of the Tags
@Sven-TBD Sven-TBD self-assigned this Aug 5, 2024
@Sven-TBD Sven-TBD moved this to 👀 Testing in CKB Explorer Aug 5, 2024
@Sven-TBD Sven-TBD moved this from 👀 Testing to 📌CurrentWeek in CKB Explorer Aug 5, 2024
@zmcNotafraid
Copy link
Member

PR: nervosnetwork/ckb-explorer#2122.
Task 1 needs @Daryl-L to handle

@zmcNotafraid zmcNotafraid moved this from 📌CurrentWeek to 🏗 In Progress in CKB Explorer Aug 6, 2024
@Keith-CY
Copy link
Member

Keith-CY commented Aug 7, 2024

PR: nervosnetwork/ckb-explorer#2122. Task 1 needs @Daryl-L to handle

@Sven-TBD please check

@Keith-CY
Copy link
Member

Keith-CY commented Aug 8, 2024

The condition of Name Length Exceeded could be polished, not tokens like BTC, ETH are all out of the length @Sven-TBD

@Sven-TBD
Copy link
Contributor Author

@zmcNotafraid
Please update the rule, remove the minimal length limit of the TokenName

@zmcNotafraid
Copy link
Member

@zmcNotafraid Please update the rule, remove the minimal length limit of the TokenName

PR: nervosnetwork/ckb-explorer#2146

@Keith-CY
Copy link
Member

Historic data should be updated

image

@zmcNotafraid
Copy link
Member

@zmcNotafraid zmcNotafraid moved this from 🏗 In Progress to ✅ Done in CKB Explorer Aug 30, 2024
@zmcNotafraid
Copy link
Member

PR: nervosnetwork/ckb-explorer#2181

  • remove unnamed tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants