Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Copy nodetype name from nodeinfoview without hyphens #3763

Merged
merged 2 commits into from
Apr 11, 2024
Merged

BUGFIX: Copy nodetype name from nodeinfoview without hyphens #3763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
603e2f4
BUGFIX: Copy nodetype name from nodeinfoview without hyphens
Sebobo Apr 10, 2024
d43c294
TASK: Add i18n label for copy nodetypename to clipboard button
Sebobo Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Resources/Private/Translations/en/Main.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@
<trans-unit id="errorBoundary.footer" xml:space="preserve">
<source>For more information about the error please refer to the JavaScript console.</source>
</trans-unit>
<trans-unit id="copyNodeTypeNameToClipboard" xml:space="preserve">
<source>Copy node type to clipboard</source>
</trans-unit>
</body>
</file>
</xliff>
32 changes: 28 additions & 4 deletions packages/neos-ui-views/src/NodeInfoView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {connect} from 'react-redux';
import {$get} from 'plow-js';
import {neos} from '@neos-project/neos-ui-decorators';
import {selectors} from '@neos-project/neos-ui-redux-store';
import IconButton from '@neos-project/react-ui-components/src/IconButton/';
import style from './style.module.css';

@connect(state => ({
Expand All @@ -22,6 +23,19 @@ export default class NodeInfoView extends PureComponent {
i18nRegistry: PropTypes.object.isRequired
}

nodeTypeNameRef = React.createRef();

copyNodeToClipboard = () => {
this.nodeTypeNameRef.current.select();
const result = document.execCommand('copy');

if (result) {
this.props.addFlashMessage('copiedToClipboard', 'Copied nodetype to clipboard', 'success');
} else {
this.props.addFlashMessage('copiedToClipboardFailed', 'Could not copy to clipboard', 'error');
}
}

render() {
const {focusedNodeContextPath, getNodeByContextPath, i18nRegistry} = this.props;

Expand All @@ -36,8 +50,8 @@ export default class NodeInfoView extends PureComponent {
};

const nodeType = $get('nodeType', node);
// Insert soft hyphens after dots and colon to make the node type more readable
const hyphenatedNodeTypeName = nodeType.replace(/([.:])/g, '$1\u00AD');
// Insert word breaking tags to make the node type more readable
const wrappingNodeTypeName = nodeType?.replace(/([:.])/g, '<wbr/>$1');

return (
<ul className={style.nodeInfoView}>
Expand All @@ -62,8 +76,18 @@ export default class NodeInfoView extends PureComponent {
<NodeInfoViewContent>{properties.name}</NodeInfoViewContent>
</li>
<li className={style.nodeInfoView__item} title={nodeType}>
<div className={style.nodeInfoView__title}>{i18nRegistry.translate('type', 'Type', {}, 'Neos.Neos')}</div>
<NodeInfoViewContent>{hyphenatedNodeTypeName}</NodeInfoViewContent>
<div
className={style.nodeInfoView__title}>{i18nRegistry.translate('type', 'Type', {}, 'Neos.Neos')}</div>
<textarea ref={this.nodeTypeNameRef} className={style.nodeInfoView__nodeTypeTextarea}>{nodeType}</textarea>
<NodeInfoViewContent>
<span dangerouslySetInnerHTML={{__html: wrappingNodeTypeName}}></span>
</NodeInfoViewContent>
<IconButton
className={style.nodeInfoView__copyButton}
icon="copy"
title={i18nRegistry.translate('copyNodeTypeNameToClipboard', 'Copy node type to clipboard', {}, 'Neos.Neos.Ui')}
onClick={this.copyNodeToClipboard}
/>
</li>
</ul>
);
Expand Down
19 changes: 19 additions & 0 deletions packages/neos-ui-views/src/NodeInfoView/style.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
}

.nodeInfoView__item {
position: relative;
background-color: var(--colors-ContrastDarkest);
padding: 8px 12px;
margin-bottom: 1px;
Expand Down Expand Up @@ -33,3 +34,21 @@
hyphenate-character: '';
word-wrap: break-word;
}

.nodeInfoView__nodeTypeTextarea {
opacity: 0;
width: 0;
height: 0;
overflow: hidden;
border: 0;
position: absolute;
}

.nodeInfoView__copyButton {
position: absolute;
top: 5px;
right: 5px;
width: 30px;
min-width: 30px;
height: 30px;
}
Loading