Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Copy nodetype name from nodeinfoview without hyphens #3763

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Apr 10, 2024

Fixes a regression introduced in #3663 by using the wbr tag instead of the shy character which is part of the copied text. The wbr tag is ignored.

Also adds a copy button for easier interaction.
This change keep the feature that the nodetype name wraps when it’s longer than the inspector is wide.

CleanShot 2024-04-10 at 22 16 09@2x

Also adds a copy button for easier interaction.
This change keep the feature that the nodetype name wraps when it’s longer than the inspector is wide.
@Sebobo Sebobo added Bug Label to mark the change as bugfix 8.3 labels Apr 10, 2024
@Sebobo
Copy link
Member Author

Sebobo commented Apr 10, 2024

The alignment of the copy button is a bit off, as I aligned it based on its hover state:

CleanShot 2024-04-10 at 22 19 57@2x

When I align it with the Type text then the hover state looks off.

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care!
+1 by reading

Copy link
Member

@ahaeslich ahaeslich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by 👀

@ahaeslich ahaeslich merged commit 4e2ed9c into 8.3 Apr 11, 2024
10 checks passed
@ahaeslich ahaeslich deleted the bugfix/copy-nodetypename-without-hyphens branch April 11, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 Bug Label to mark the change as bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants