-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Extract job ID from saucelabs #3698
TASK: Extract job ID from saucelabs #3698
Conversation
f173fa5
to
0a2b039
Compare
0a2b039
to
d6e4482
Compare
5808d78
to
1740397
Compare
fc1e086
to
721e508
Compare
995660a
to
17baf49
Compare
17baf49
to
b11853c
Compare
🎥 End-to-End Test Recordings These videos demonstrate the end-to-end tests for the changes in this pull request. |
b11853c
to
ff94c49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much. Thanks that you went thought that shell hell for us. I would have probably taken 1 hour for every shell line 😂 How do you do this???
As you see, the commits has been force pushed several times and I needed lots of commits :D |
This is just ci and stuff. We wont be needing it for development as we dont develop on 7.3 anymore. So id say 8.3 should be it ;) |
However, I would like to explain why I think this PR is still useful and important. As you know, we still need to provide security patches for this branch, even though we are not actively developing new features or fixing bugs. For that purpose, it is helpful to have a reliable and fast way to run the tests and check the results. It also does not hurt to have it and is easy to upmerge. |
Okay then let’s do it ;) I will not oppose any further. |
Hu but this caused a sideeffect that made the tests actually harder to read. I triggered now 5 test runs until i found out that the logs are written to Also it seems the links were dead for the last prs i tried this feature on, sorry to inform you about that :/ |
Yes not seeing the current progress it a bit of a bummer, i would vouch for putting it into the log BUT most importantly keeping the output as it happens on the cli. Also it seems the feature doesnt work any longer since a month now, maybe its too complex to maintain for us? Having the github bot create a comment and stuff is great, but if its more stable to post the link to the recordings at the end of the run in the console output i would really like that. Especially as the comments got me hyped into thinking someone reviewed my pr, but it was just the bot :O |
Could you please revert this, or am i allowed to do so? ^^ As it A doesnt work and B obscures the logs and makes things harder to understand. Sorry that your effort dint pay out. But it guess this is just a too big complexity with relatively little gain? |
Description
This pull request addresses issue #2762.
In our end-to-end tests, we currently leverage Sauce Labs for recording video. However, the video link is accessible only to team members, limiting visibility for non-team members. To enhance transparency and allow contributors to view the recording without the need for local setup, this pull request introduces a script or GitHub Action.
The script or action automates the process of extracting the Sauce Labs video link and posts it as a comment on the corresponding pull request. With this enhancement, non-team members can easily access and review the video recording, gaining valuable insights into the end-to-end test results.
Changes Made