BUGFIX: Store artifacts for logs #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjust the path to the AcceptanceTesting.log
markusguenther
force-pushed
the
bugfix/adjust-artifacts-circleci
branch
3 times, most recently
from
3947fc5 to
be24387
Compare
The saucelabs test buffers to output to a file, and therefore we have no visible output. This should prevent a test break after 10 minutes.
markusguenther
force-pushed
the
bugfix/adjust-artifacts-circleci
branch
from
be24387 to
8877060
Compare
|
🎥 End-to-End Test Recordings These videos demonstrate the end-to-end tests for the changes in this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3698
The recent modification, which involved adding an end-to-end (e2e) recording step to generate a comment in the pull request (PR), encountered a problem with the logs. Consequently, the logs were no longer being attached correctly. To address this issue, we have implemented a solution where we now store the artifacts and pass through the logs from the acceptance tests to the workspace. This ensures that the logs are appropriately utilized in the subsequent step, which involves creating a comment in the PR.