Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Remove empty tests #3386

Merged
merged 2 commits into from
Feb 22, 2023
Merged

TASK: Remove empty tests #3386

merged 2 commits into from
Feb 22, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Feb 18, 2023 •
edited
Loading

solves #3370

ONLY tests were remove which content is EXACTLY

test(`write tests`, () => {
    expect(true).toBe(true);
});

markusguenther
markusguenther approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@markusguenther markusguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No all the valuable tests :P

Thanks for the cleanup.

@markusguenther
Copy link
Member

We could also remove them in 7.3... would save time on all PRs ;)

@mhsdesign
Copy link
Member Author

hmm it sure is about a minute we can save ^^

@mhsdesign mhsdesign changed the base branch from 8.3 to 7.3 February 21, 2023 13:00
@mhsdesign mhsdesign marked this pull request as draft February 21, 2023 13:01
@mhsdesign mhsdesign marked this pull request as ready for review February 21, 2023 21:38
@mhsdesign mhsdesign merged commit 40ada0f into 7.3 Feb 22, 2023
@mhsdesign mhsdesign deleted the task/removeEmptyTests branch February 22, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusguenther markusguenther markusguenther approved these changes

Assignees
No one assigned
Labels
7.3 Task
Projects
No open projects
Neos & Flow 8.3 Release Board
Status: Done ✅
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhsdesign @markusguenther