Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unusefull tests expect(true).toBe(true); #3370

Closed
mhsdesign opened this issue Feb 15, 2023 · 3 comments
Closed

Remove unusefull tests expect(true).toBe(true); #3370

mhsdesign opened this issue Feb 15, 2023 · 3 comments

Comments

@mhsdesign
Copy link
Member

i think one assertion is enough ;) currently we have 101
@JamesAlias
Copy link
Contributor

I think those tests were some kind of reminder to actually write real tests ^^

@mhsdesign
Copy link
Member Author

yes but they might slow down testing and falsify our trust into them ;)
Also realistically - no one will anytime soon write the tests :P

@JamesAlias
Copy link
Contributor

agreed 😅

@mhsdesign mhsdesign mentioned this issue Feb 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@markusguenther @JamesAlias @mhsdesign