BUGFIX: Colocate react-ui-components esm-build declarations and sources #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fine by reading ;) |
mhsdesign
approved these changes
Jan 17, 2023
The relative import in the selectbox component forced typescript to create a different file structure for the source files than for the declaration files causing issues with importing the esm build. By using the package style import the folder structure is correct again and by defining the rootDir in the tsconfig file an error will be thrown if a relative include outside of the components package is used. Resolves: #3329
Sebobo
force-pushed
the
bugfix/esm-build
branch
from
789cdec
to
6073de8
Compare
grebaldi
approved these changes
Jan 17, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relative import in the selectbox component forced typescript to create a different file structure for the source files than for the declaration files causing issues with importing the esm build.
By using the package style import the folder structure is correct again and by defining the rootDir in the tsconfig file an error will be thrown if a relative include outside of the components package is used.
Resolves: #3329