Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM build of react-ui-components source files in wrong place #3329

Closed
Sebobo opened this issue Jan 12, 2023 · 0 comments · Fixed by #3336
Closed

ESM build of react-ui-components source files in wrong place #3329

Sebobo opened this issue Jan 12, 2023 · 0 comments · Fixed by #3336
Labels
7.3 Bug Label to mark the change as bugfix

Comments

@Sebobo
Copy link
Member

Sebobo commented Jan 12, 2023 •
edited
Loading

Description

Since Neos.UI 7.3.6 or even earlier the source are in a different folder than their declaration files from the react-ui-components ESM build, making it hard to use.
Only the d.ts files are contained are in the correct place.

Expected behavior

Source files are present and can be imported

Actual behavior

Source files are missing and import is not possible

Affected Versions

Neos: 7+

UI: 7.3.6 or earlier. 5.3.13 is still working
@Sebobo Sebobo added the Bug Label to mark the change as bugfix label Jan 12, 2023
@Sebobo Sebobo changed the title ESM build of react-ui-components is missing source files ESM build of react-ui-components source files in wrong place Jan 16, 2023
Sebobo added a commit that referenced this issue Jan 16, 2023
@Sebobo
BUGFIX: Colocate react-ui-components esm-build declarations and sources
789cdec 
The relative import in the selectbox component forced
typescript to create a different file structure for the
source files than for the declaration files causing issues with importing the esm build.

By using the package style import the folder structure is correct again and by defining the rootDir in the tsconfig file an error will be thrown if a relative include outside of the components package is used.

Resolves: #3329
@Sebobo Sebobo mentioned this issue Jan 16, 2023
Merged
@grebaldi grebaldi linked a pull request Jan 17, 2023 that will close this issue
BUGFIX: Colocate react-ui-components esm-build declarations and sources #3336
Merged
@grebaldi grebaldi added the 7.3 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
7.3 Bug Label to mark the change as bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUGFIX: Colocate react-ui-components esm-build declarations and sources neos/neos-ui
2 participants
@Sebobo @grebaldi