BUGFIX: Adjust module path to distribution #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the package is "compiled" the build will not handle typescript and expect a JavaScript module. As we create a distribution, we should target the dist folder.
|
Ok seems we need to change the path while the release :/ |
Adds make adjust-extensibility to modify the module parameter path for the production build of the neos-ui-extensibility.
grebaldi
pushed a commit
to grebaldi/PackageFactory.Guevara
that referenced
this pull request
Jan 10, 2023
* BUGFIX: Adjust module path to distribution When the package is "compiled" the build will not handle typescript and expect a JavaScript module. As we create a distribution, we should target the dist folder. * TASK: Add command for extensibility adjustment Adds make adjust-extensibility to modify the module parameter path for the production build of the neos-ui-extensibility. * TASK: Check if jq is installed on the release machine
mhsdesign
added a commit
that referenced
this pull request
Feb 15, 2023
This reverts commit 3abef29.
mhsdesign
added a commit
that referenced
this pull request
Feb 17, 2023
* Revert "TASK: Handling extensibility module path (#3316)" This reverts commit d48f9c8. * Revert "BUGFIX: Adjust module path to distribution (#3314)" This reverts commit 3abef29. * Task: Ts use "target": "ES2020", * Task: Fix make help * Task: typescript dont transpile to javascript standarts older than dinosaurs * Task: use publishConfig.main to solve conditional exports https://yarnpkg.com/configuration/manifest#publishConfig * Task; use `workspace:*` selector also in npm packages dependencies * Task: speed up `bump-version` from 1m18s to 10s * Task: remove ./Build/createVersionFile.sh script and use esbuild define
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the package is "compiled" the build will not handle typescript and expect a JavaScript module. As we create a distribution, we should target the dist folder.