Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Build extensiblity plugins without class transform #3290

Merged
merged 2 commits into from
Jan 1, 2023

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Dec 7, 2022

Relates: #3287

What I did

How I did it

How to verify it

Build the Neos extensibility examples

@Sebobo
Copy link
Member Author

Sebobo commented Dec 22, 2022

@markusguenther we also need to downgrade babel from 7 to 6 as its a dependency of build-essentials.

@grebaldi
Copy link
Contributor

Sorry, I didn't mean to intervene here 😅

But since I've been fiddling around with Visol.Neos.LinkClass and was able to verify that this branch + babel downgrade fixed the issue I've encountered there, I took the liberty of pushing my changes.

Please feel free to handle my changes as you see fit :)

@markusguenther markusguenther marked this pull request as ready for review January 1, 2023 21:24
@markusguenther markusguenther merged commit f07fe35 into 8.2 Jan 1, 2023
@markusguenther markusguenther deleted the bugfix/build-compatible-plugins branch January 1, 2023 21:24
@markusguenther
Copy link
Member

BTW: Tested that change with the extensibility examples, and it worked nice after the test release with 8.2.1-beta1 I figured out that the build had the issue with typescript. The reason was that the dist folder is not used.

So, I now adjust the module path while the release.
More in the PR #3314

But with that, it works perfect and the people just need to add "@neos-project/build-essentials": "version-number", to the own plugin.

@markusguenther
Copy link
Member

Can be tested:

The packages just need to change the dependencies like that.

"@neos-project/neos-ui-extensibility": "8.2.1-beta2",
"@neos-project/build-essentials": "8.2.1-beta2"

@grebaldi
Copy link
Contributor

grebaldi commented Jan 2, 2023

Hi @markusguenther,

thanks a lot for those beta releases!

I was able to successfully test them with Visol.Neos.LinkClass.

grebaldi added a commit to grebaldi/PackageFactory.Guevara that referenced this pull request Jan 10, 2023
* BUGFIX: Build extensiblity plugins without class transform

Relates: neos#3287

* TASK: Downgrade `babel-core` from 7 to 6

Co-authored-by: Wilhelm Behncke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants