Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Fix module path in package.json #3284

Merged
merged 2 commits into from
Dec 2, 2022
Merged

BUGFIX: Fix module path in package.json #3284

merged 2 commits into from
Dec 2, 2022

Conversation

Sebobo
Copy link
Member

@Sebobo Sebobo commented Nov 30, 2022

No description provided.

@Sebobo Sebobo force-pushed the bugfix/positional-array-sorter-resolution branch from 4ca10f5 to 8d5baba Compare November 30, 2022 21:46
@mhsdesign
Copy link
Member

nenennenennennen das mach ich schon :)

@Sebobo
Copy link
Member Author

Sebobo commented Dec 1, 2022

What do you mean?

@mhsdesign
Copy link
Member

ups hab den diff falsch gelesen

@markusguenther
Copy link
Member

English please 🙃

@Sebobo
Copy link
Member Author

Sebobo commented Dec 2, 2022

So is this fix now correct or not?
The referenced file before does not exist and my IDE also complained about it.

@mhsdesign
Copy link
Member

hmm yes i tried to understand why ci fails ... it seems pretty much correct... odd that i missed this at all

(thanks for noticing and trying to fix it)

@markusguenther
Copy link
Member

hmm yes i tried to understand why ci fails ... it seems pretty much correct... odd that i missed this at all

It is not just CI. You can see that locally as well!

@mhsdesign
Copy link
Member

I give up for now ... i couldnt fix it ...

i tried various typescript settings (https://www.typescriptlang.org/tsconfig#moduleResolution to Node16 Node12 NodeNext) upgraded typescript from 4.7 (now) to 4.9 and set other useless options in the tsconfig ...

i think, we might be able to fix this one case manually by telling typescript where to find the array sorter, but that defeats the purpose of yarn workspaces.

So ultimately we want to fix

typescript yarn workspaces cannot find module

hmmm wow:

"main": "./src/positionalArraySorter.ts",
works too - but we want to distribute cjs and esm at the same time no? #3262

@markusguenther
Copy link
Member

Thanks for this fix.

Tried it locally and the tests say that everything is fine, but we have some console errors inside the tests.
Checked the last 8.1 run and there were not console.errors. (https://app.circleci.com/pipelines/github/neos/neos-ui/2764/workflows/8c1dd7b7-268d-430f-9ccf-07eab162ff0c/jobs/12663)

For instance this one.
Screenshot 2022-12-02 at 22 30 27

@markusguenther
Copy link
Member

But these console.errors are not related to that change. So this helps to bring us forward :)
Also tested now with "@neos-project/positional-array-sorter": "^8.2.1" as dependency in the extensibility instead of the 8.1.4

@markusguenther markusguenther merged commit 7e0bfc6 into 8.2 Dec 2, 2022
@markusguenther markusguenther deleted the bugfix/positional-array-sorter-resolution branch December 2, 2022 21:40
@markusguenther
Copy link
Member

Created an issue for the errors, so that we don't miss it #3288

@mhsdesign
Copy link
Member

thx for all the testing.
see #3258 for tge console errors ;)

grebaldi pushed a commit to grebaldi/PackageFactory.Guevara that referenced this pull request Jan 10, 2023
@Sebobo @mhsdesign @grebaldi
BUGFIX: Fix module path in package.json (neos#3284)
496cb93 
* BUGFIX: Fix module path in package.json

* WTF: am i doing with my life

Co-authored-by: mhsdesign <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusguenther markusguenther Awaiting requested review from markusguenther

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sebobo @mhsdesign @markusguenther