Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: All 8.2 neos npm packages need to be delayed released and checked if they still work after esbuild change #3262

Closed
3 tasks done
mhsdesign opened this issue Nov 24, 2022 · 2 comments

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Nov 24, 2022

By changing the build system from webpack to esbuild in #3200 and partly banning babel - a lot of internals change.

This issue holds left todos from #3200

Following sub packages of this monorepo are affected:

Todos

  • re add main fields and build subpackages command for npm subsplits
  • check if neos-ui-extensiblity still works (bable stuff) did we update babel?
  • fix scss files in lib esm build of react-ui-components
@mhsdesign mhsdesign changed the title Task: All 8.2 neos npm packages need to be delayed released and checked if the still work after esbuild change Task: All 8.2 neos npm packages need to be delayed released and checked if they still work after esbuild change Nov 24, 2022
@mhsdesign
Copy link
Member Author

Following things where changed:

packages/neos-ui-extensibility/package.json

  • "main": "./dist/index.js", -> "module": "./src/index.ts",

packages/positional-array-sorter/package.json

  • "main": "./dist/positionalArraySorter.js", -> "module": "./src/positionalArraySorter.js",

also in packages/react-ui-components/package.json we must make sure via esbuid to always use the "main" field instead of "module"

@markusguenther
Copy link
Member

We in the Jenkins release task we now change the module folder from src to dist and then we are using the babel transpiled code. So we can close this ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants