Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page_service: getpage batching: refactor & minor fixes #9792

Closed
wants to merge 18 commits into from
Closed

page_service: getpage batching: refactor & minor fixes #9792

wants to merge 18 commits into from
+331 −64

Commits on Nov 18, 2024

  1. WIP: page_service: add basic testcase for merging 

    The steps in the test work in neon_local + psql
but for some reason they don't work in the test.

Asked compute team on Slack for help:
https://neondb.slack.com/archives/C04DGM6SMTM/p1731952688386789
    @problame
    problame committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    0689965 View commit details
    Browse the repository at this point in the history

  2. got it working and turn it more into a benchmark

    @problame
    problame committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    15e21c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. compiles

    @problame
    problame committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    61ff84a View commit details
    Browse the repository at this point in the history

  2. fixes

    @problame
    problame committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    911946a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. parametrize more test

    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    5cc0059 View commit details
    Browse the repository at this point in the history

  2. switch back to tokio::time::sleep, to get the numbers 

    => https://www.notion.so/neondatabase/benchmarking-notes-143f189e004780c4a630cb5f426e39ba?pvs=4#144f189e00478054b8a3e325735ffa19

=> unacceptable
    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b974616 View commit details
    Browse the repository at this point in the history

  3. make it a proper benchmark

    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f2de5b5 View commit details
    Browse the repository at this point in the history

  4. collect CPU utilization

    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e80ce97 View commit details
    Browse the repository at this point in the history

  5. bench fixups

    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    75041cb View commit details
    Browse the repository at this point in the history

  6. page_service: add benchmark for batching 

    This PR adds a benchmark to demonstrate the effect of server-side
getpage request batching added in #9321.

Refs:

- Epic: #9376
- Extracted from #9792
    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b695907 View commit details
    Browse the repository at this point in the history

  7. Revert "switch back to tokio::time::sleep, to get the numbers" 

    This reverts commit b974616.
    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    aa695b2 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'problame/batching-benchmark' into problame/merge-getpag… 

    …e-test
    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    88d52b3 View commit details
    Browse the repository at this point in the history

  9. fixup whitespace stuff

    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    b299eb1 View commit details
    Browse the repository at this point in the history

  10. Revert "Revert "switch back to tokio::time::sleep, to get the numbers"" 

    This reverts commit aa695b2.
    @problame
    problame committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    af95320 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. high-resolution CPU usage

    @problame
    problame committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    e82deb2 View commit details
    Browse the repository at this point in the history

  2. pytest.approx; #9820 (comment)

    @problame
    problame committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3375f28 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into problame/batching-ben… 

    …chmark
    @problame
    problame committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    ff0aa15 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'problame/batching-benchmark' into problame/merge-getpag… 

    …e-test
    @problame
    problame committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    058b35f View commit details
    Browse the repository at this point in the history