page_service: getpage batching: refactor & minor fixes #9792
+331
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 18, 2024
5535 tests run: 5309 passed, 0 failed, 226 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
058b35f at 2024-11-21T11:30:41.601Z :recycle: |
problame
added a commit
that referenced
this pull request
Nov 18, 2024
## Problem We don't take advantage of queue depth generated by the compute on the pageserver. We can process getpage requests more efficiently by batching them. ## Summary of changes Batch up incoming getpage requests that arrive within a configurable time window (`server_side_batch_timeout`). Then process the entire batch via one `get_vectored` timeline operation. By default, no merging takes place. ## Testing * **Functional**: #9792 * **Performance**: will be done in staging/pre-prod # Refs * #9377 * #9376 Co-authored-by: Christian Schwarz <[email protected]>
Base automatically changed from
vlad/pageserver-merge-get-page-requests
to
main
November 18, 2024 20:24
problame
changed the title
problame
changed the title
The steps in the test work in neon_local + psql but for some reason they don't work in the test. Asked compute team on Slack for help: https://neondb.slack.com/archives/C04DGM6SMTM/p1731952688386789
problame
force-pushed
the
problame/merge-getpage-test
branch
from
a149e89
to
15e21c7
Compare
problame
changed the title
problame
changed the title
This reverts commit aa695b2.
problame
changed the title
problame
changed the title
VladLazar
approved these changes
Nov 21, 2024
This was referenced Nov 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
This PR adds two benchmark to demonstrate the effect of server-side getpage request batching added in #9321. For the CPU usage, I found the the `prometheus` crate's built-in CPU usage accounts the seconds at integer granularity. That's not enough you reduce the target benchmark runtime for local iteration. So, add a new `libmetrics` metric and report that. The benchmarks are disabled because [on our benchmark nodes, timer resolution isn't high enough](https://neondb.slack.com/archives/C059ZC138NR/p1732264223207449). They work (no statement about quality) on my bare-metal devbox. They will be refined and enabled once we find a fix. Candidates at time of writing are: - #9822 - #9851 Refs: - Epic: #9376 - Extracted from #9792
|
The changes in this PR will be largely replaced by which is currently stacked on top. Closing this to avoid one merge-rebase-CI roudtrip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the page_service server-side batching code that was recently added in
#9377.
Changes:
handle_pagestream, instead of in thePageServerHandler. This adds robustness because it systematically avoids a source of bugs.next_batch, call itcarry.&mut Option<Carry>of in a local variable.batchback into theself.next_batchwhenever we bail.