Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BiomeSpecialEffectsBuilder to copy backgroundMusicVolume #1792

Conversation

sciwhiz12
Copy link
Member

This PR fixes #1733 by also copying backgroundMusicVolume in the copy factory for BiomeSpecialEffectsBuilder. Tested by checking that walking into a pale garden biome with background music playing causes the music to slowly fade out, and then fade back in when walking outside of the pale garden biome. See also #1766 (comment) for a bit more information.

@sciwhiz12 sciwhiz12 added bug A bug or error 1.21.4 Targeted at Minecraft 1.21.4 labels Dec 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Dec 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 115ba26afb308cbe0876c2418b1fc70e3b4856e9.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1792' // https://github.com/neoforged/NeoForge/pull/1792
        url 'https://prmaven.neoforged.net/NeoForge/pr1792'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1792.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1792
cd NeoForge-pr1792
curl -L https://prmaven.neoforged.net/NeoForge/pr1792/net/neoforged/neoforge/21.4.40-beta-pr-1792-fix-1.21.4-GH-1733-pale-garden-music-fadeout/mdk-pr1792.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@embeddedt embeddedt merged commit 5a7d409 into neoforged:1.21.x Dec 23, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.4.39-beta.

@sciwhiz12 sciwhiz12 deleted the fix/1.21.4/GH-1733-pale-garden-music-fadeout branch December 24, 2024 01:06
Soaryn pushed a commit to Soaryn/EnergyHandlerPR that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.21.4]If you enter the Pale garden in 1.21.4. not music fade out
3 participants