[1.21.4]If you enter the Pale garden in 1.21.4. not music fade out

[baguchi]

Minecraft Version: 1.21.4
NeoForge Version: 21.4.2-beta

Description of issue:

The background music that should fade out in Pale Garden doesn't fade out.

mayby net.minecraft.client.Minecraft#getSituationalMusic is not support fade out?

[sciwhiz12]

As noted in #1766 (comment), the issue is due to BiomeSpecialEffectsBuilder failing to copy over the backgroundMusicVolume field from the original info (which is 0.0F for the pale garden biome), thus causing the modified info to hold the default value of 1.0F. The fix is as simple as modifying the builder to copy that field.

[neoforged-releases]

🚀 This issue has been resolved in NeoForge version 21.4.39-beta, as part of #1792.