Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ClaimTransaction for IsLowPriority #510

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Remove ClaimTransaction for IsLowPriority #510

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion neo/Network/P2P/Payloads/Transaction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public UInt256 Hash

InventoryType IInventory.InventoryType => InventoryType.TX;

public bool IsLowPriority => Type == TransactionType.ClaimTransaction || NetworkFee < Settings.Default.LowPriorityThreshold;
public bool IsLowPriority => NetworkFee < Settings.Default.LowPriorityThreshold;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change it to this?

public bool IsLowPriority => Type != TransactionType.ClaimTransaction && NetworkFee < Settings.Default.LowPriorityThreshold;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem that I see of not having it in a configuration, is that if it is spam, it is difficult to change. It would be easy to temporarily go to the configuration and disable the ClaimTransaction as a priority.

Copy link
Contributor

@igormcoelho igormcoelho Dec 10, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree Erik, because setting ClaimTransaction as low priority is unfair since it cannot attach fees. These transaction types should be removed anyway, let's keep just one :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In NEO 3.0, there will be only one type of transaction.


private Fixed8 _network_fee = -Fixed8.Satoshi;
public virtual Fixed8 NetworkFee
Expand Down