Remove ClaimTransaction for IsLowPriority #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is not necessary because according to neo-project/neo-modules#33 (comment) we can check that for `ClaimTransaction` is not possible to assign fee.
erikzhang
approved these changes
Dec 8, 2018
erikzhang
reviewed
Dec 9, 2018
| @@ -49,7 +49,7 @@ public UInt256 Hash | |||
|
|
|||
| InventoryType IInventory.InventoryType => InventoryType.TX; | |||
|
|
|||
| public bool IsLowPriority => Type == TransactionType.ClaimTransaction || NetworkFee < Settings.Default.LowPriorityThreshold; | |||
| public bool IsLowPriority => NetworkFee < Settings.Default.LowPriorityThreshold; | |||
There was a problem hiding this comment.
Can we change it to this?
public bool IsLowPriority => Type != TransactionType.ClaimTransaction && NetworkFee < Settings.Default.LowPriorityThreshold;There was a problem hiding this comment.
The problem that I see of not having it in a configuration, is that if it is spam, it is difficult to change. It would be easy to temporarily go to the configuration and disable the ClaimTransaction as a priority.
There was a problem hiding this comment.
I agree Erik, because setting ClaimTransaction as low priority is unfair since it cannot attach fees. These transaction types should be removed anyway, let's keep just one :)
There was a problem hiding this comment.
In NEO 3.0, there will be only one type of transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is not necessary because according to neo-project/neo-modules#33 (comment) we can check that for
ClaimTransactionis not possible to assign fee.