-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge with Upstream and Simplify Decoding #66
Conversation
willemneal
commented
Sep 3, 2019
•
edited
Loading
edited
- Decreases binaries by ~50% by defining fewer classes
- Handle Type Aliases
- Fixes stub allocation
- Loader much faster at accessing typed arrays
- Fixes typing generation
This removes IDE errors when trying use the toString method on those primitive types.
It fails the tests because the new loader changed APIs. |
- simplified testing - added test artifacts for future reference
@willemneal LGTM, but let's create demo fiddle on studio (overriding compiler in setup.js) to make sure this works |
Okay I'll make one now. Could we set this up to use the render bot? |
This uses the new URL asc parameter from nearprotocol/NEARStudio#154 But here is this commit on the live site: https://studio.nearprotocol.com/?f=p8h1iu1hq |
Issue was that compiler wouldn't allow `Obj | Uint8array` so to get around it added a type parameter that has a default.
Do you mind pulling the latest upstream again? The resolver fix would be quite useful. |
Do you mind merging master so that we can easily see results of vm tests? |
Sure just updating merging with upstream and there were some issues introduced by the second to last PR so I'm going to merge the one before it. |
What was the issue? |
Not exactly sure. The errors are internal to bignum and it no longer likes the way I handled |
So I narrowed down the error from the type resolution PR to bignum. I just created a PR there: MaxGraey/as-bignum#27 to fix it. For now I just merged with the PR before it and we can return after bignum is fixed. |
@vgrichina I also changed the API so that |