Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new type resolution in asc #27

Merged
merged 4 commits into from
Sep 18, 2019

Conversation

willemneal
Copy link
Contributor

Currently fails tests. Looking into it.

@willemneal
Copy link
Contributor Author

@MaxGraey Not sure why it's failing travis. I switched the combination operators, e.g. <<= 1, to their full forms so that it would compile. I just checked the newest fix @dcode merged to fix this issue and it still doesn't work. Since near's production code now relies on this package, could we merge this for now (after figuring out why travis is mad) and then have a later PR when the compiler is resolved?

@MaxGraey
Copy link
Owner

@willemneal In local I can't build wasm module as well:

Require stack:
- ////bignum.wasm/bignum.wasm/node_modules/assemblyscript/cli/asc.js
- ////node_modules/assemblyscript/bin/asc
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@MaxGraey MaxGraey merged commit 40cc5f5 into MaxGraey:master Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants