-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to include the current version in history table #63
Conversation
I'd be pretty interested in this too since this makes it much easier to see current and historic data at a glance. |
@mcesar can you please explain what this PR does and the motivation why you would need this? |
@simoneb this PR gives the option to store the current version in history table together with the old versions. When applied, it will provide a easier way to query data given a timestamp. For example, given a table a. current behavior: SELECT * FROM t WHERE x <@ sys_period
UNION
SELECT * FROM t_history WHERE x <@ sys_period; b. with SELECT * FROM t_history WHERE x <@ sys_period; |
Considering that this has a simple solution in user space and that it would deviate from the original implementation that we're trying to adhere to, I don't see a compelling reason to include this feature, but happy to be convinced otherwise |
I see, I assumed that deviation from original implementation was not an issue because of this part of the readme:
|
It's not an issue per-se, but this has a very simple solution in user space |
As the number of tables grows so does the number of workarounds. I am versioning 21 tables and I have to create 21 views when stepping through historic data. This PR would simplify my life by a lot. |
If there is demand for this feature, I'm not strongly against including it. We just need to make sure that, if possible, this doesn't result in a breaking change for existing users, and that the default will remain that of not including the current version in the history table. |
This I would find this extremely useful. Running the union for me is prohibitively expensive at inference time, meaning I then have to introduce a delay to do it periodically using cron. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.