-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace unmaintained parity-secp256k1 to secp256k1 #7000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahlinc
force-pushed
the
replace-secp256k1-lib
branch
from
June 9, 2022 05:57
b5cafb7
to
b4f0e0e
Compare
mina86
reviewed
Jun 9, 2022
This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks. |
I'm getting this error. Is there any temporary fix?
|
You shouldn’t need to compile it for wasm32 though? |
mm-near
approved these changes
Sep 6, 2022
mina86
approved these changes
Sep 6, 2022
nikurt
pushed a commit
that referenced
this pull request
Sep 7, 2022
This PR replaces an unmaintained fork of secp256k1 to the latest version of the original library that already have all required features with a more clear API. Also this will solve compilation issues with llvm 13.* tools on MacOS like the next: rust-lang/rust-bindgen#1834
birchmd
added a commit
to near/near-workspaces-rs
that referenced
this pull request
Oct 4, 2022
ChaoticTempest
pushed a commit
to near/near-workspaces-rs
that referenced
this pull request
Oct 4, 2022
….15.0 for nearcore libraries (#210) * Chore: Upgrade to version 0.4.0 of near-jsonrpc-client, and version 0.15.0 for nearcore libraries * Fix expected random secp256k1 key. This change is needed due to near/nearcore#7000 * Remove deserialization from into_state_map. It is no longer needed since nearcore updated the view types to not be serialized
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
This PR replaces an unmaintained fork of secp256k1 to the latest version of the original library that already have all required features with a more clear API. Also this will solve compilation issues with llvm 13.* tools on MacOS like the next: rust-lang/rust-bindgen#1834
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces an unmaintained fork of secp256k1 to the latest version of the original library that already have all required features with a more clear API. Also this will solve compilation issues with llvm 13.* tools on MacOS like the next: rust-lang/rust-bindgen#1834