Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace unmaintained parity-secp256k1 to secp256k1 #7000

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Jun 8, 2022

This PR replaces an unmaintained fork of secp256k1 to the latest version of the original library that already have all required features with a more clear API. Also this will solve compilation issues with llvm 13.* tools on MacOS like the next: rust-lang/rust-bindgen#1834

@ahlinc ahlinc requested a review from a team as a code owner June 8, 2022 22:56
@ahlinc ahlinc requested a review from mzhangmzz June 8, 2022 22:56
@ahlinc ahlinc force-pushed the replace-secp256k1-lib branch from b5cafb7 to b4f0e0e Compare June 9, 2022 05:57
@matklad matklad requested a review from mm-near June 9, 2022 07:41
core/crypto/src/signature.rs Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jun 23, 2022

This PR has been automatically marked as stale because it has not had recent activity in the 2 weeks.
It will be closed in 3 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Jun 23, 2022
@akhi3030 akhi3030 removed the S-stale label Jul 8, 2022
@longnguyencircle
Copy link

longnguyencircle commented Aug 22, 2022

I'm getting this error. Is there any temporary fix?

cargo build --target wasm32-unknown-unknown --release                                                             101 ↵
   Compiling parity-secp256k1 v0.7.0
   Compiling toml v0.5.9
   Compiling wasm-bindgen-macro v0.2.82
   Compiling serde_json v1.0.83
   Compiling near-rpc-error-core v0.14.0
   Compiling num-rational v0.3.2
   Compiling curve25519-dalek v3.2.1
The following warnings were emitted during compilation:

warning: depend/secp256k1/contrib/lax_der_parsing.c:7:10: fatal error: 'string.h' file not found
warning: #include <string.h>
warning:          ^~~~~~~~~~
warning: 1 error generated.

error: failed to run custom build command for `parity-secp256k1 v0.7.0`

@mina86
Copy link
Contributor

mina86 commented Aug 27, 2022

You shouldn’t need to compile it for wasm32 though?

core/crypto/src/signature.rs Show resolved Hide resolved
@near-bulldozer near-bulldozer bot merged commit 8fe52e3 into near:master Sep 6, 2022
nikurt pushed a commit that referenced this pull request Sep 7, 2022
This PR replaces an unmaintained fork of secp256k1 to the latest version of the original library that already have all required features with a more clear API. Also this will solve compilation issues with llvm 13.* tools on MacOS like the next: rust-lang/rust-bindgen#1834
birchmd added a commit to near/near-workspaces-rs that referenced this pull request Oct 4, 2022
ChaoticTempest pushed a commit to near/near-workspaces-rs that referenced this pull request Oct 4, 2022
….15.0 for nearcore libraries (#210)

* Chore: Upgrade to version 0.4.0 of near-jsonrpc-client, and version 0.15.0 for nearcore libraries

* Fix expected random secp256k1 key. This change is needed due to near/nearcore#7000

* Remove deserialization from into_state_map. It is no longer needed since nearcore updated the view types to not be serialized
nikurt pushed a commit that referenced this pull request Nov 9, 2022
This PR replaces an unmaintained fork of secp256k1 to the latest version of the original library that already have all required features with a more clear API. Also this will solve compilation issues with llvm 13.* tools on MacOS like the next: rust-lang/rust-bindgen#1834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants