Chore: Upgrade to version 0.4.0 of near-jsonrpc-client, and version 0.15.0 for nearcore libraries #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….15.0 for nearcore libraries
…nce nearcore updated the view types to not be serialized
ChaoticTempest
approved these changes
Oct 4, 2022
ChaoticTempest
deleted the
birchmd/chore/upgrade-near-jsonrpc-client-0.4.0
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
near-jsonrpc-clientwas officially released, so we do not need to depend on the-beta.0version any more.This upgrade is important because cargo thinks that
0.4.0-beta.0should be compatible with0.4.0, however they are not due to the different versions of the nearcore libraries. This means thatworkspacesfails to compile as a dependency of other crates (unless thenear-jsonrpc-clientversion is fixed to thebetaone inCargo.lock).Along with the upgrade, there were a few minor API changes in the nearcore libraries which meant we needed to make a few extra changes here (namely around encoding values as base64 / base 58).