fix: ulimit error #241
Merged
fix: ulimit error #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
force-pushed
the
fix/ulimit
branch
from
29e446b to
255b1e8
Compare
ChaoticTempest
force-pushed
the
fix/ulimit
branch
from
255b1e8 to
9f8c59e
Compare
|
tested on Windows WSL2 and fixes the issue |
miraclx
approved these changes
Jan 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure if this actually fixes #237, but it should according to nearcore code. Still need to test this with ulimits set below certain bounds, but this also provides a way to manually override the max open files with an environment var.
We shouldn't need to configure an env var for every configurable in
config.jsonthough, but requires #220 to make it in first before we can offer easier ways to configure things (by passing in configs into the sandbox builder)