feat: workspaces::sandbox() can connect to user provided sandbox node #220
Conversation
ChaoticTempest
force-pushed
the
feat/network-builder
branch
from
c3da830 to
404ff36
Compare
|
Rebased this with latest changes on workspaces. @itegulov let me know how it looks when you get the chance |
| "Cleaning up sandbox: port={:?}, pid={}", | ||
| rpc_port, |
There was a problem hiding this comment.
For messages like these, isn't just a port lossy? Especially since custom sandbox Urls could technically have no port. So this would just be None.
There was a problem hiding this comment.
good point, this was old messaging that I forgot and didn't notice to change. Thanks for pointing this out
| @@ -111,22 +148,20 @@ impl Drop for SandboxServer { | |||
| return; | |||
| } | |||
|
|
|||
| let rpc_port = self.rpc_port(); | |||
| let child = self.process.as_mut().unwrap(); | |||
There was a problem hiding this comment.
I believe this would panic for custom sandbox urls.
There was a problem hiding this comment.
For custom sandbox URLs, there's no process spawned, so child would be None here and early return in the above:
if self.process.is_none() {
return;
}There was a problem hiding this comment.
Ah, that code path was collapsed in the diff. Looks good.
There was a problem hiding this comment.
Wanna try this at the top instead?
let child = match self.process.take() {
Some(child) => child,
None => return,
};
|
hey @ChaoticTempest , as I stated on discord , I am trying to integrate workspaces local/sandbox tests with the kurtosis local environment, would it be possible to use this branch to connect to it ? if not what roadblock would prevent me from doing it ? |
|
@miraclx any objections to merging this? |
This adds a
Builderto the return type ofworkspaces::sandbox()which is another async builder so that users can parameterize what RPC url they want to point to if they have a different RPC node pointing to that network. For this PR, only sandbox was done, and will addtestnetandmainnetafter since those are pretty trivial in comparison.Sandbox now basically has the ability to connect to a user's own locally spawned sandbox node.