Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1160: add exact amount display method #9

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

lauchaves
Copy link
Contributor

@lauchaves lauchaves commented Jul 31, 2024

Description

  • This PR fix issue #1160 from near-sdk

  • Need to add the exact_amount_display method to format yoctoNEAR values for clearer error messages in near-sdk storage management.

Implementation

  • Added exact_amount_display Method: it formats NearToken amounts for display as yoctoNEAR or NEAR.
  • Based on exact-display implementation from near-cli-rs
  • Added tests for various cases: zero value, small values, exact NEAR values, and fractional NEAR values.

Example Usage:

let required_cost = NearToken::from_yoctonear(15 * 10_u128.pow(23));
format!("Must attach {} to cover storage", required_cost.exact_amount_display())

@lauchaves
Copy link
Contributor Author

@frol this one is ready for review!

Copy link
Contributor

@akorchyn akorchyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd like to invite you to participate in the Race of Sloths. Just mention @race-of-sloths user in your GitHub comment or PR description to join!

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lauchaves Great! Thank you for bringing tests to it as well!

Indeed, consider joining the @race-of-sloths

@frol frol merged commit 8b3b15c into near:main Jul 31, 2024
5 checks passed
@frol frol mentioned this pull request Jul 31, 2024
@lauchaves
Copy link
Contributor Author

Hey @frol, @akorchyn, I didn't know about the Race of Sloths! I just joined, that's super cool! Thanks so much for the invite! 🦥🚀

@lauchaves
Copy link
Contributor Author

@race-of-sloths pls, include my pr in the race!

@race-of-sloths
Copy link

race-of-sloths commented Jul 31, 2024

@lauchaves Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

The average score is 2

@lauchaves check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@race-of-sloths
Copy link

🔄 The PR has been merged.

Important

This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️

@frol
Copy link
Collaborator

frol commented Jul 31, 2024

@race-of-sloths score 2

@race-of-sloths
Copy link

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 2!
You have received 30 (20 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @lauchaves! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants