-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1160: Fix storage management error message with proper amount #1222
1160: Fix storage management error message with proper amount #1222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lauchaves Thank you for the contribution! Let us address #1223 to get CI green before we can merge this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, bump the near-token crate version to the latest one that now includes your fix
near-sdk-rs/near-sdk/Cargo.toml
Line 35 in 0f46b0d
near-token = { version = "0.2.0", features = ["serde", "borsh"] } |
@frol done! |
@race-of-sloths please, include me |
@lauchaves Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 1 @lauchaves check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
e873582
to
1b09abb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lauchaves Thank you!
@race-of-sloths score 1
🌟 Score recorded!@frol, thank you for scoring this pull request in the Race of Sloths! |
✅ PR is finalized!Your contribution is much appreciated with a final score of 1! We would appreciate your feedback or contribution idea that you can submit here |
Description
This PR fix issue #1160 from near-sdk
Need to add the
exact_amount_display
method to formatyoctoNEAR
values for clearer error messageThis requires the Near-token pull request to be merged first.
Implementation
exact_amount_display
to formatNearToken
values