Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refund deposit back to the caller on failure to create a DAO #2

Closed
ilblackdragon opened this issue Jan 27, 2021 · 1 comment
Closed

Refund deposit back to the caller on failure to create a DAO #2

ilblackdragon opened this issue Jan 27, 2021 · 1 comment

Comments

@ilblackdragon
Copy link
Collaborator

Currently if DAO creation fails via factory - the deposit kept on factory's balance.

To fix this, the callback must be handled and checked if the account creation / deployment was successful.
@DenysOf DenysOf mentioned this issue Feb 12, 2021
Closed
@ilblackdragon
Copy link
Collaborator Author

Addressed in v2.

ilblackdragon pushed a commit that referenced this issue Sep 25, 2024
@referencedev @TrevorJTClarke
@marco-sundsk @think-in-universe
Merging set of fixes for upgrading smart contracts on Nightshade v2 (#…
3d568f9 
…206)

* Added scripts for handling v2 gas fixes and scripts for mainnet

* Added remaining mainnet scripts

* finished gasfix testing in testnet

* Finalized all scripts for mainnet use

* Fixed script typo

* Add docker build files. Update script for factory upgrade

* Bumping the gas required to delete the temp contract

* handle argument gas cost increasing (#1)

Co-authored-by: Marco <[email protected]>

* remove sputnikdao2_gasfix and fix binaryen version in github workflows (#2)

Co-authored-by: Marco <[email protected]>

* ci: fix test failure (#3)

* ci: run test on macos-13

* ci: use llvm@14 on macos

* test: refactor tests with near-workspaces-js and ava

* test: refactor tests and fix failure

* ci: test on ubuntu-24.04 with node 20.17.0

* ci: test on ubuntu-22.04 with node 20.17.0

---------

Co-authored-by: Trevor Clarke <[email protected]>
Co-authored-by: Marco <[email protected]>
Co-authored-by: Marco <[email protected]>
Co-authored-by: Robert Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilblackdragon