Merging set of fixes for upgrading smart contracts on Nightshade v2 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Marco <[email protected]>
|
To fix the build failure, install the latest Replace the binaryen version 105 with version 119 in sputnik-dao-contract/.github/workflows/build.yml Lines 91 to 92 in 2b19edb => curl -L https://github.com/WebAssembly/binaryen/releases/download/version_119/binaryen-version_119-x86_64-linux.tar.gz | tar xzf -
echo "`pwd`/binaryen-version_119/bin" >> $GITHUB_PATH |
|
The test failure is caused by the Is the |
#2) Co-authored-by: Marco <[email protected]>
* ci: run test on macos-13 * ci: use llvm@14 on macos * test: refactor tests with near-workspaces-js and ava * test: refactor tests and fix failure * ci: test on ubuntu-24.04 with node 20.17.0 * ci: test on ubuntu-22.04 with node 20.17.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains mix of fixes:
Merging it all into main so we have the up to date version that is going to be used by Ref Finance and probably other DAOs.