Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed the filename helper.R to setup.R #45

Merged
merged 2 commits into from
Oct 20, 2020
Merged

changed the filename helper.R to setup.R #45

merged 2 commits into from
Oct 20, 2020

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Oct 20, 2020

Fix #44 (or at least try to :-) )

@codecov-io
Copy link

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines          435       435           
=========================================
  Hits           435       435           
Impacted Files Coverage Δ
R/use-httptest.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88dc7b5...538058f. Read the comment docs.

Copy link
Owner

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@nealrichardson nealrichardson merged commit 1fcb2be into nealrichardson:master Oct 20, 2020
nealrichardson pushed a commit that referenced this pull request Dec 21, 2020
* changed the filename `helper.R` to `setup.R`

* fix
@jonocarroll
Copy link

FYI, https://enpiar.com/r/httptest/ has the files for v3.3.0 and so still has the old suggestion. Thanks for this package, it's fantastic!

@nealrichardson
Copy link
Owner

Thanks, yeah I'm overdue to update the websites (and do another CRAN release, for that matter).

@nealrichardson
Copy link
Owner

Website update now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_httptest() should create a file called setup not helper
4 participants