Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_httptest() should create a file called setup not helper #44

Closed
maelle opened this issue Oct 16, 2020 · 3 comments · Fixed by #45
Closed

use_httptest() should create a file called setup not helper #44

maelle opened this issue Oct 16, 2020 · 3 comments · Fixed by #45

Comments

@maelle
Copy link
Contributor

maelle commented Oct 16, 2020

https://testthat.r-lib.org/reference/test_dir.html#special-files
@nealrichardson nealrichardson changed the title Should use_httptest() create a file called setup not helper? use_httptest() should create a file called setup not helper Oct 16, 2020
@nealrichardson
Copy link
Owner

Apparently it should :) Revised the issue title accordingly.

@maelle maelle mentioned this issue Oct 20, 2020
Merged
@maelle
Copy link
Contributor Author

maelle commented Oct 21, 2020

Actually this might have been a bad idea? r-lib/testthat#1206 (comment)

@maelle
Copy link
Contributor Author

maelle commented Oct 21, 2020

I got confused, it was the right change https://testthat.r-lib.org/articles/test-fixtures.html#package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed the filename helper.R to setup.R
2 participants
@nealrichardson @maelle