Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop -> Master merge, Release v5.33.0 #159

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Develop -> Master merge, Release v5.33.0 #159

merged 10 commits into from
Oct 7, 2024

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Oct 7, 2024

syphax-bouazzouni and others added 10 commits April 17, 2024 16:24
…portal-lirmm/goo into ontoportal-lirmm-pr/feature/update-resource-seetings
multilingual solr schema has multivalued perfLabels which is
not handleled in the goo.  This would not be an issue once schemaless
solr is adopted
…resource-seetings

Feature: Update resource settings to use a YAML file to get attributes metadata & implement onUpdate callback
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.04762% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (70007fa) to head (74a012e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
lib/goo/base/resource.rb 92.59% 2 Missing ⚠️
lib/goo/validators/enforce.rb 77.77% 2 Missing ⚠️
lib/goo/validators/validator.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   86.98%   87.47%   +0.49%     
==========================================
  Files          36       37       +1     
  Lines        2627     2675      +48     
==========================================
+ Hits         2285     2340      +55     
+ Misses        342      335       -7     
Flag Coverage Δ
unittests 87.47% <94.04%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr merged commit f943ac3 into master Oct 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants