Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update resource settings to use a YAML file to get attributes metadata & implement onUpdate callback #158

Merged

Conversation

alexskr
Copy link
Member

@alexskr alexskr commented Oct 1, 2024

see #151

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 94.04762% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.47%. Comparing base (9b15e24) to head (caee0b4).

Files with missing lines Patch % Lines
lib/goo/base/resource.rb 92.59% 2 Missing ⚠️
lib/goo/validators/enforce.rb 77.77% 2 Missing ⚠️
lib/goo/validators/validator.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #158      +/-   ##
===========================================
+ Coverage    86.98%   87.47%   +0.49%     
===========================================
  Files           36       37       +1     
  Lines         2627     2675      +48     
===========================================
+ Hits          2285     2340      +55     
+ Misses         342      335       -7     
Flag Coverage Δ
unittests 87.47% <94.04%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexskr alexskr merged commit 74a012e into develop Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants