Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design property #106

Merged
merged 34 commits into from
Jan 21, 2025
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
afbcb65
New slick design base
mamikals Dec 3, 2024
5c5a726
added new template for filter component + fixed bug with filter funct…
saramoh2309 Dec 3, 2024
0ca8440
added changes for filter + group timeline
saramoh2309 Dec 5, 2024
ef4e6ea
Merge remote-tracking branch 'origin/master' into designProperty
mamikals Dec 9, 2024
82e6683
Add customComponent to slick view
mamikals Dec 9, 2024
79d234a
styling fixes
saramoh2309 Dec 10, 2024
c5cd458
fix design + refactor code + run prettier
saramoh2309 Dec 11, 2024
033feb3
expandable item
saramoh2309 Dec 11, 2024
9258ca0
Update prettier version
mamikals Dec 13, 2024
0713716
Add multiple header support for slick design
mamikals Dec 13, 2024
d5f2f05
Delete whitespace
mamikals Dec 17, 2024
72b9168
Merge branch 'designProperty' into designPropertyCopy
mamikals Dec 17, 2024
81d9c16
Remove showSubtitle and add custom clamp line amount
mamikals Dec 19, 2024
740cd01
Merge pull request #104 from navikt/designPropertyCopy
mamikals Dec 20, 2024
c370112
Merge branch 'master' into designProperty
mamikals Dec 20, 2024
71df7f4
resolve comment
saramoh2309 Jan 6, 2025
cf4bc01
removed duplicates
saramoh2309 Jan 6, 2025
e94e2b5
Update thread view dependency
mamikals Jan 6, 2025
28933b9
Fix review comments
mamikals Jan 7, 2025
675b287
Send logEvent down to custom component
mamikals Jan 7, 2025
d4c58fd
Update force-app/main/default/lwc/timeline/timeline.js-meta.xml
mamikals Jan 8, 2025
4d52c3c
Reform getDateFormat to be more readable
mamikals Jan 8, 2025
ff7a5fb
Fix unexpected token error
mamikals Jan 9, 2025
e4d9ab4
Update date error handling
mamikals Jan 14, 2025
233ffee
Merge branch 'master' into designProperty
mamikals Jan 14, 2025
82e9726
do not show Load More if records is filtered + remove "Tomt"
saramoh2309 Jan 14, 2025
de962f5
removed border if user has no cases
saramoh2309 Jan 14, 2025
c99408d
removed isLoadig from Load More
saramoh2309 Jan 14, 2025
6fc7ef8
Adjust line size and distance
mamikals Jan 15, 2025
bb48c84
Fix issues with data loading by using the old code instead
mamikals Jan 16, 2025
a1dfdf3
Merge remote-tracking branch 'origin/designProperty' into fixForFilter
mamikals Jan 17, 2025
7bb1a5b
Use modified data for filter and record count
mamikals Jan 20, 2025
99e513c
Merge pull request #109 from navikt/fixForFilter
mamikals Jan 20, 2025
339404c
fixed filter
EirikFladby Jan 21, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
styling fixes
saramoh2309 committed Dec 10, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 79d234ac994f9e9eccda8cd7430c786ceed97a4e
18 changes: 8 additions & 10 deletions force-app/main/default/lwc/timeline/slick.css
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
.custom-border {
.custom-container {
align-items: flex-start;
border-bottom: 1px solid #767676;
padding: 0 1rem;
}

.custom-header {
margin-bottom: 1.25rem;
.left-column {
padding-top: 4rem;
padding-bottom: 1.25rem;
}

.custom-filter {
margin-bottom: 1.5rem;
padding-top: 1rem;
}

.custom-padding {
padding: 1rem 1rem 0 1rem;
.right-column {
padding-top: 1.75rem;
}
44 changes: 19 additions & 25 deletions force-app/main/default/lwc/timeline/slick.html
Original file line number Diff line number Diff line change
@@ -1,30 +1,24 @@
<template>
<div class="slds-theme_default slds-is-relative">
<div class="custom-padding">
<div class="slds-grid slds-border_bottom custom-border">
<div class="slds-col slds-large-size_8-of-12 slds-align-bottom custom-header">
<h3 class="slds-card__header-title">
<lightning-icon
icon-name={headerIcon}
size="small"
class="slds-var-m-right_small"
></lightning-icon>
{header}
</h3>
</div>
<div class="slds-col slds-large-size_4-of-12 custom-filter">
<c-timeline-filter
lwc:if={filterIsActive}
filter-properties={filterProperties}
is-grouped={isGrouped}
picklist-filter-1-label={picklistFilter1Label}
picklist-filter-2-label={picklistFilter2Label}
hide-my-activities-filter={hideMyActivitiesFilter}
onfilterchange={handleFilter}
log-event={logEvent}
design={design}
></c-timeline-filter>
</div>
<div class="slds-grid custom-container">
<div class="slds-col slds-large-size_8-of-12 left-column">
<h3 class="slds-card__header-title">
<lightning-icon icon-name={headerIcon} size="small" class="slds-var-m-right_small"></lightning-icon>
{header}
</h3>
</div>
<div class="slds-col slds-large-size_4-of-12 right-column">
<c-timeline-filter
lwc:if={filterIsActive}
filter-properties={filterProperties}
is-grouped={isGrouped}
picklist-filter-1-label={picklistFilter1Label}
picklist-filter-2-label={picklistFilter2Label}
hide-my-activities-filter={hideMyActivitiesFilter}
onfilterchange={handleFilter}
log-event={logEvent}
design={design}
></c-timeline-filter>
</div>
</div>
<div lwc:if={loading} class="slds-scrollable" style={loadingStyle}>
14 changes: 12 additions & 2 deletions force-app/main/default/lwc/timelineGroup/slick.css
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.slds-accordion__section {
border-bottom: 1px solid #767676;
margin: 1rem;
margin: 0.813rem 1rem 1rem 1rem;
--slds-c-accordion-section-spacing-block-end: 0;
--slds-c-accordion-section-spacing-block-start: 0;
--slds-c-accordion-section-spacing-inline-end: 0;
@@ -30,6 +30,16 @@
position: absolute;
top: 100%;
z-index: 0;
max-height: 1rem;
max-height: 1.75rem;
margin-top: 0.1rem;
}

.custom-button {
padding: 0.5rem 0;
margin-bottom: 0.25rem;
}

.custom-header {
justify-content: center;
vertical-align: middle;
}
4 changes: 2 additions & 2 deletions force-app/main/default/lwc/timelineGroup/slick.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<template>
<section class={accordionSectionClass}>
<div class="slds-accordion__summary slds-var-p-bottom_small">
<h2 class="slds-accordion__summary-heading">
<h2 class="slds-accordion__summary-heading custom-header">
<button
class="slds-button slds-button_reset slds-accordion__summary-action slds-var-p-vertical_xx-small"
class="slds-button slds-button_reset slds-accordion__summary-action custom-button"
aria-expanded={isExpanded}
onclick={toggleButton}
>
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/timelineGroup/timelineGroup.js
Original file line number Diff line number Diff line change
@@ -66,7 +66,7 @@ export default class TimelineGroup extends LightningElement {
}

get accordionSectionClass() {
return this.isOpen ? 'slds-accordion__section slds-is-open' : 'slds-accordion__section slds-is-closed';
return `slds-accordion__section ${this.isOpen ? 'slds-is-open' : 'slds-is-closed'}`;
}

get isExpanded() {
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/timelineItem/sharedStyling.css
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.row {
margin-bottom: 1.4em;
margin-bottom: 1.5rem;
}

.table {
2 changes: 1 addition & 1 deletion force-app/main/default/lwc/timelineItem/slick.css
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@

.cell-icon {
margin-top: 0.35rem;
border: 0.15em solid white;
border: 0.2em solid white;
--slds-c-icon-radius-border: 1rem;
}