Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design property #106

Merged
merged 34 commits into from
Jan 21, 2025
Merged

Design property #106

merged 34 commits into from
Jan 21, 2025

Conversation

mamikals
Copy link
Contributor

No description provided.

mamikals
mamikals commented Dec 20, 2024
View reviewed changes
Copy link
Contributor Author

@mamikals mamikals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg merget inn #104 til denne branchen så alt kunne ses på med en gang, men hadde noen kommentarer på den som jeg skriver her. Jeg tok også bort showSubtitle propertyen, jeg er ikke sikker på hva den skulle gjøre?

force-app/main/default/lwc/timeline/timeline.js Outdated Show resolved Hide resolved
force-app/main/default/lwc/timelineItem/slick.html Outdated Show resolved Hide resolved
vegarduri
vegarduri requested changes Dec 23, 2024
View reviewed changes
Copy link

@vegarduri vegarduri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut :) Har noen små kommentarer som egentlig bare er forslag.

force-app/main/default/classes/Timeline_Model.cls Show resolved Hide resolved
force-app/main/default/lwc/timeline/timeline.js-meta.xml Outdated Show resolved Hide resolved
force-app/main/default/lwc/timelineDate/timelineDate.js Show resolved Hide resolved
force-app/main/default/lwc/timelineGroup/slick.html Show resolved Hide resolved
force-app/main/default/lwc/timelineGroup/timelineGroup.js Outdated Show resolved Hide resolved
force-app/main/default/lwc/timelineItem/timelineItem.js Show resolved Hide resolved
force-app/main/default/lwc/timelineItem/timelineItem.js Outdated Show resolved Hide resolved
EirikFladby
EirikFladby approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@EirikFladby EirikFladby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Godt stykke arbeid, Herr Marton! 🥇

force-app/main/default/classes/Timeline_Helper.cls Show resolved Hide resolved
force-app/main/default/lwc/timeline/timeline.js-meta.xml Outdated Show resolved Hide resolved
force-app/main/default/lwc/timeline/timeline.js-meta.xml Outdated Show resolved Hide resolved
force-app/main/default/lwc/timelineDate/timelineDate.js Outdated Show resolved Hide resolved
@saramoh2309 saramoh2309 merged commit 6d3c597 into master Jan 21, 2025
5 of 6 checks passed
@saramoh2309 saramoh2309 deleted the designProperty branch January 21, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saramoh2309 saramoh2309 saramoh2309 left review comments

@vegarduri vegarduri vegarduri requested changes

@EirikFladby EirikFladby EirikFladby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mamikals @EirikFladby @saramoh2309 @vegarduri