Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Candlestick (OHLC) chart #76

Closed
JamieWritesCode opened this issue Jul 15, 2017 · 5 comments
Closed

Support for Candlestick (OHLC) chart #76

JamieWritesCode opened this issue Jul 15, 2017 · 5 comments
Labels
feature
Milestone
3.0

Comments

@JamieWritesCode
Copy link

I know it's only early days, but is there any intent to ship a candlestick chart? Seems to be a popular request across many charting libraries.

alt Candlestick Chart

Google Charts for reference:
https://developers.google.com/chart/interactive/docs/gallery/candlestickchart
@netil
Copy link
Member

netil commented Jul 17, 2017

thanks @TehCrucible for the suggestion!
Of course, candlestick type is one of the types that we care, but I can't not guarantee in very near future.
We'll be implementing new type by type and candlestick will be one of them definitely.

@netil netil added the feature label Jan 4, 2018
@netil netil mentioned this issue Dec 23, 2019
Closed
@rolandblain
Copy link

any updates?

@netil
Copy link
Member

netil commented Nov 19, 2020

Planning for 2021.

@michkami
Copy link
Collaborator

Would it also be possbile to support waterfall charts if candlestick is implemented?
It does not seem to be much work to support it, after candlestick is implemented.

@netil
Copy link
Member

netil commented Mar 3, 2021

@rolandblain @JamieWritesCode, sorry for the long wait on this.

Want to share that new candlestick type works almost reaching the end 😃 !
Within few days, the updates will be merged to d3v6 branch and planning to release on v3.

@netil netil added this to the 3.0 milestone Mar 4, 2021
netil referenced this issue in netil/billboard.js Mar 5, 2021
@netil
feat(candlestick): Intent to ship candlestick
2f1c73a 
- Implement new 'candlestick' type chart
- Fix bubble/scatter type to work on subchart
- Refactor subchart to use shape’s node generate & update
- Move .getBarW() to shape.ts to be used from bar and candlestick type

Ref #76
@netil netil mentioned this issue Mar 5, 2021
Merged
netil referenced this issue in netil/billboard.js Mar 5, 2021
@netil
feat(candlestick): Intent to ship candlestick
437c737 
- Implement new 'candlestick' type chart
- Fix bubble/scatter type to work on subchart
- Refactor subchart to use shape’s node generate & update
- Move .getBarW() to shape.ts to be used from bar and candlestick type

Ref #76
netil referenced this issue in netil/billboard.js Mar 5, 2021
@netil
feat(candlestick): Intent to ship candlestick
b253b77 
- Implement new 'candlestick' type chart
- Fix bubble/scatter type to work on subchart
- Refactor subchart to use shape’s node generate & update
- Move .getBarW() to shape.ts to be used from bar and candlestick type

Ref #76
netil referenced this issue in netil/billboard.js Mar 5, 2021
@netil
feat(shape): Intent to ship candlestick
27d7c5b 
Implement new candlestick type

Ref #76
netil referenced this issue in netil/billboard.js Mar 5, 2021
@netil
feat(candlestick): Intent to ship candlestick
f628e8d 
- Implement new 'candlestick' type chart
- Fix bubble/scatter type to work on subchart
- Refactor subchart to use shape’s node generate & update
- Move .getBarW() to shape.ts to be used from bar and candlestick type

Ref #76
netil added a commit that referenced this issue Mar 5, 2021
@netil
feat(candlestick): Intent to ship candlestick
8d37bd8 
- Implement new 'candlestick' type chart
- Fix bubble/scatter type to work on subchart
- Refactor subchart to use shape’s node generate & update
- Move .getBarW() to shape.ts to be used from bar and candlestick type

Fix #76
Close #1167
@netil netil closed this as completed Mar 5, 2021
github-actions bot pushed a commit that referenced this issue Mar 5, 2021
@semantic-release-bot
chore(release): 3.0.0-next.2 [skip ci]
33657be 
# [3.0.0-next.2](3.0.0-next.1...3.0.0-next.2) (2021-03-05)

### Bug Fixes

* **api:** fix loading area-line-range ([fe46492](fe46492)), closes [#1938](#1938)
* **legend:** fix hiding via .hide() ([c489a77](c489a77)), closes [#1950](#1950)
* **legend:** legend.inset.anchor is working again ([b5ba930](b5ba930)), closes [#1935](#1935) [#1936](#1936)
* **zoom:** fix x Axis tick transition during zoom ([3f08b11](3f08b11)), closes [#1949](#1949)

### Features

* **candlestick:** Intent to ship candlestick ([8d37bd8](8d37bd8)), closes [#76](#76) [#1167](#1167)
* **candlestick:** Intent to ship candlestick type ([42307cb](42307cb))
github-actions bot pushed a commit that referenced this issue Mar 26, 2021
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
9285212 
# [3.0.0](2.2.6...3.0.0) (2021-03-26)

### Bug Fixes

* **axis:** fix axis.x.max error throw ([de06361](de06361)), closes [#1981](#1981)
* **axis:** fix axis.x.tick.tooltip on rotated axis ([eed2f86](eed2f86)), closes [#1990](#1990)
* **subchart:** fix duplicated node generation on data load ([d9a5d9a](d9a5d9a)), closes [#2003](#2003)
* **zoom:** fix zoom on latest chrome ([37edc9b](37edc9b)), closes [/github.com/d3/d3-zoom/issues/231#issuecomment-802305692](https://github.com//github.com/d3/d3-zoom/issues/231/issues/issuecomment-802305692) [#1992](#1992)

### Features

* **all:** update for d3 v6 ([2752e55](2752e55)), closes [#1641](#1641)
* **api:** Enhance .export() option to specify size ([3c2de80](3c2de80)), closes [#815](#815) [#1969](#1969)
* **api:** Intent to ship subchart APIs ([5572dc9](5572dc9)), closes [#1993](#1993)
* **candlestick:** Intent to ship candlestick ([8d37bd8](8d37bd8)), closes [#76](#76) [#1167](#1167)
* **candlestick:** Intent to ship candlestick type ([42307cb](42307cb))

### BREAKING CHANGES

* **all:** - Update to work on d3 v6
- Added getPoint() to get event's position coordinate

https://github.com/d3/d3/blob/master/CHANGES.md
https://observablehq.com/d/f91cccf0cad5e9cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
4 participants
@netil @JamieWritesCode @michkami @rolandblain