-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply D3 v6 updates #1641
Comments
I assume this will make billboard also drop the old ES support? Or are you looking for a way to update and still support IE11? |
Not for in near future, but as the D3.js goes to the direction dropping the old legacy support, it will come the moment of the decision. I already wrote a guide about this before, but seems not really effective, because it needs some work from the user level. Maintaining "as-is" isn't a long term solution also. @michkami what's your opinion? |
Personally I completely agree with you. Sooner or later, dropping old browser support will be necessary. But from the perspective of our customers, IE11 support is necessary, as many of them still don't want (or can). As soon as Microsoft completely replaces IE with the new chromium based Edge, they will be forced to use atleast the Edge, which supports ES6. When do you plan to update to v6? |
The worldwide IE market share is just about I can't determine the schedule for that for now. Need to hear more feedbacks from the users. I'll be looking for possible workaround on this, and let me know if you have one :) |
AFAIK, d3 v6 can run fine in IE 11 (at least the parts I tried) if you follow a few steps :
These steps are reasonable to expect for projects which still need to maintain support for IE 11 IMO. The real issue comes when using non-polyfillable non-transpilable features, but that's few of them. Ideally, the list of necessary polyfills should be documented though In my opinion, billboard.js should not be loading these polyfills and performing the transpiling (except for the special pkgd build), to keep the benefits of smaller modern code for projects not needing IE 11 (and to avoid loading polyfills multiple times in projects supporting IE 11). Note however that this might require a new major version of billboard, in case d3 BC breaks leak in the public API (I'm thinking about the |
For reference, at Incenteev, we currently have 4.6% of IE 11 users (hurray for big companies not migrating to modern browsers...), and we already rely on several libraries which don't ship transpiled code anymore. We only faced once an issue where a library was using a non-polyfillable runtime feature (and they were OK to use a different solution to avoid that). Of course, from times to times, we get issues due to a missing polyfill, but that's easy to fix. |
Sorry for the harsh question, but is there any new Information or ETA on this issue? Imho IE Support ist negligible, i understand that some cooperations still use it (some of our clients, still use it - but they have a second browser installed for "modern" applications / applications which do not support IE). Also: Just because a new major version of billboard releases (which would be necessary i guess because of breaking changes?), people are not forced to update to this version. You can continue to run the older version as long as you need (you won't get the bugfixes tho) The reason i ask for this is, that we use d3js for other charts and drawings then billboard, but we can not upgrade since billboard does not support the new version. I really appriciate your work on billboard, the sentences above are just my opinion and are not meant as criticism, just as additional input to this conversation which might or might not be helpful. |
@toitzi thanks for sharing.
I can't give an exact ETA, but hopefully to be done within 1 ~ 2 months. |
Currently I'm working on for d3v6 update and did for basic functionality. Maybe it can be out for |
- Update to work on d3 v6 - Added getPoint() to get event's position coordinate https://github.com/d3/d3/blob/master/CHANGES.md https://observablehq.com/d/f91cccf0cad5e9cb Ref naver#1641
My initial plan was releasing as part or But, aside of the release version, I want hear broad opinions as possible for the support of d3v6, where main possible difficulties for the users will be the dropping legacy browser(ex. IE11) support. It's clear that whole JS(Node.js) ecosystem's library going to that direction since a while, so the right direction is going forward. But also there're necessities to cover legacy browser environment. One of the possible alternative will be,
|
For me personally it would be ok to update to Also releasing |
@netil Personally i also would be ok to update to |
- Update to work on d3 v6 - Added getPoint() to get event's position coordinate https://github.com/d3/d3/blob/master/CHANGES.md https://observablehq.com/d/f91cccf0cad5e9cb Ref #1641
Given that there are already a bunch of fixes planned for 2.2, I would suggest making a 2.2 release containing these fixes, and then a 3.0 release with the d3v6 work just after that. @michkami not that you can still probably use IE 11 with the newer version, if you take care of 2 steps:
|
BREAKING CHANGE: - Update to work on d3 v6 - Added getPoint() to get event's position coordinate https://github.com/d3/d3/blob/master/CHANGES.md https://observablehq.com/d/f91cccf0cad5e9cb Ref #1641
# [3.0.0-next.1](2.2.2...3.0.0-next.1) (2021-02-08) ### Features * **all:** update for d3 v6 ([2752e55](2752e55)), closes [#1641](#1641) ### BREAKING CHANGES * **all:** - Update to work on d3 v6 - Added getPoint() to get event's position coordinate https://github.com/d3/d3/blob/master/CHANGES.md https://observablehq.com/d/f91cccf0cad5e9cb
now you can download d3 v6 support version, directly from npm registry by: npm i billboard.js@next |
Thanks for doing this. Updates like this are definitely big positives in considering whether to use Billboard or C3. |
# [3.0.0](2.2.6...3.0.0) (2021-03-26) ### Bug Fixes * **axis:** fix axis.x.max error throw ([de06361](de06361)), closes [#1981](#1981) * **axis:** fix axis.x.tick.tooltip on rotated axis ([eed2f86](eed2f86)), closes [#1990](#1990) * **subchart:** fix duplicated node generation on data load ([d9a5d9a](d9a5d9a)), closes [#2003](#2003) * **zoom:** fix zoom on latest chrome ([37edc9b](37edc9b)), closes [/github.com/d3/d3-zoom/issues/231#issuecomment-802305692](https://github.com//github.com/d3/d3-zoom/issues/231/issues/issuecomment-802305692) [#1992](#1992) ### Features * **all:** update for d3 v6 ([2752e55](2752e55)), closes [#1641](#1641) * **api:** Enhance .export() option to specify size ([3c2de80](3c2de80)), closes [#815](#815) [#1969](#1969) * **api:** Intent to ship subchart APIs ([5572dc9](5572dc9)), closes [#1993](#1993) * **candlestick:** Intent to ship candlestick ([8d37bd8](8d37bd8)), closes [#76](#76) [#1167](#1167) * **candlestick:** Intent to ship candlestick type ([42307cb](42307cb)) ### BREAKING CHANGES * **all:** - Update to work on d3 v6 - Added getPoint() to get event's position coordinate https://github.com/d3/d3/blob/master/CHANGES.md https://observablehq.com/d/f91cccf0cad5e9cb
Description
D3 new major release v6 came out, and need to look for the support & migration.
The main affected will be:
d3.event
, replacing it by passing as event param.Refs.
The text was updated successfully, but these errors were encountered: