Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] On axis click #2587

Closed
pedrorfernandes opened this issue Mar 13, 2022 · 2 comments
Closed

[Feature Request] On axis click #2587

pedrorfernandes opened this issue Mar 13, 2022 · 2 comments

Comments

@pedrorfernandes
Copy link

Description

I have a use case for displaying a time series stacked bar chart, in which clicking a specific point on the X (time) axis should update an html video to the timestamp that was clicked (i.e. use the chart as a video scrubber)

The issue is that onclick processing is only done with associated data ([x,y] point), but for my scenario, every second does not necessarily have a data point associated (only x, no y value). It doesn't make sense to add a y value for each second of the video, as this pollutes the chart and the interpolated Y values are good enough.

Desired output

The solution I found was through this change, basically adding a axis_onclick called inside clickHandlerForSingleX()

Is there a better way to handle this requirement? Does it make sense to have an axis onClick?

@netil
Copy link
Member

netil commented Mar 16, 2022

which clicking a specific point on the X (time) axis

This means clicking axis area or shape(where the bar, line renders) area?
.clickHandlerForSingleX() is called on shape area's event, not for axis.

@pedrorfernandes
Copy link
Author

Ok then it's working for me because I've used a stacked area chart that covers 100% of the axis

Still, it would be useful for a click handler for anywhere in the chart region with just the mapped [X,Y] coordinates of the click, without associated data

netil added a commit to netil/billboard.js that referenced this issue Mar 18, 2022
Implement onclick option

Ref naver#2587
@netil netil closed this as completed in 63c5a53 Mar 18, 2022
github-actions bot pushed a commit that referenced this issue Mar 24, 2022
# [3.4.0-next.2](3.4.0-next.1...3.4.0-next.2) (2022-03-24)

### Bug Fixes

* **api:** Fix flow on indexed/category axis type ([4aba436](4aba436)), closes [#2595](#2595)

### Features

* **api:** Implement axis range reset ([6c9d99e](6c9d99e)), closes [#2398](#2398)
* **option:** Intent to ship onclick ([63c5a53](63c5a53)), closes [#2587](#2587)
github-actions bot pushed a commit that referenced this issue Mar 31, 2022
# [3.4.0](3.3.3...3.4.0) (2022-03-31)

### Bug Fixes

* **api:** Fix flow on indexed/category axis type ([4aba436](4aba436)), closes [#2595](#2595)
* **axis:** Fix culling visibility on dynamic loading ([4c79daf](4c79daf)), closes [#2582](#2582)
* **axis:** fix hidden axis rescale on dynamic load ([5418853](5418853)), closes [#2523](#2523) [#2571](#2571)
* **generator:** Prevent possible infinite loop when tab isn't visible ([bafdb17](bafdb17)), closes [#2606](#2606)
* **option:** Fix data.hide not working for bubble/scatter type ([64ae74b](64ae74b)), closes [#2609](#2609)
* **util:** Check if agent has mouse ([d42adaa](d42adaa)), closes [#2550](#2550) [#2585](#2585)
* **util:** Enhance parsing date string ([8d9f422](8d9f422)), closes [#1714](#1714)

### Features

* **api:** Implement axis range reset ([6c9d99e](6c9d99e)), closes [#2398](#2398)
* **option:** Intent to ship onclick ([63c5a53](63c5a53)), closes [#2587](#2587)
* **polar:** Intent to ship polar type ([feca715](feca715)), closes [#2462](#2462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants