fix(axis): fix hidden axis rescale on dynamic load

Remove conditional added from #2523 Fix #2571
naver · Feb 25, 2022 · 5418853 · 5418853
1 parent 82f1058
commit 5418853
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/ChartInternal/Axis/Axis.ts b/src/ChartInternal/Axis/Axis.ts
@@ -894,7 +894,7 @@ class Axis {
 			const prefix = `axis_${key}_`;
 			const axisScale = scale[key];
 
-			if (config[`${prefix}show`] && axisScale) {
+			if (axisScale) {
 				const tickValues = config[`${prefix}tick_values`];
 				const tickCount = config[`${prefix}tick_count`];
 

diff --git a/test/internals/axis-spec.ts b/test/internals/axis-spec.ts
@@ -2291,6 +2291,26 @@ describe("AXIS", function() {
 				expect(main.select(`.bb-axis-${v}`).style("visibility")).to.be.equal("hidden");
 			});
 		});
+
+		it("y Axis domain should update even is hidden", done => {
+			const yDomain = chart.internal.scale.y.domain();
+
+			// when
+			chart.load({
+				columns: [
+					['data1', 500, 600, 500, 4000, 750, 2000],
+					['data2', 123, 444, 555, 112, 3321, 232],
+				],
+				done: function() {
+					// after dynamic data load, y axis domain should be updated
+					expect(yDomain).to.not.be.deep.equal(
+						this.internal.scale.y.domain()
+					);
+
+					done();
+				}
+			});
+		});
 	});
 
 	describe("Multi axes", () => {