Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When axis.rotated options set, y Axis clip-path dimension set wrong value #1572

Closed
netil opened this issue Jul 29, 2020 · 0 comments
Closed

When axis.rotated options set, y Axis clip-path dimension set wrong value #1572

netil opened this issue Jul 29, 2020 · 0 comments
Assignees
@netil
Labels
bug
Milestone
Patch

Comments

@netil
Copy link
Member

netil commented Jul 29, 2020 •
edited
Loading

Description

When axis.rotated=true option is used, y Axis isn't visible.

The issue comes from the wrong <clipPath> element's dimension.
Workaround for this is setting axis.y.clipPath=false option to remove the use of "clip-path" attribute.

<clipPath id="bb-1596001448689-clip-yaxis"><rect x="-20" y="-40" width="708" height="60"></rect></clipPath>
@netil netil added the bug label Jul 29, 2020
@netil netil added this to the Patch milestone Jul 29, 2020
@netil netil self-assigned this Jul 29, 2020
netil added a commit to netil/billboard.js that referenced this issue Jul 29, 2020
@netil
fix(axis): fix y axis clip-path coordinates
756e1f0 
- Fix wrong y attribute value when axis is rotated
- Fix wrong interface name for y/y2 definition file

Ref naver#1572
@netil netil mentioned this issue Jul 29, 2020
Merged
@netil netil closed this as completed in bdf7694 Jul 29, 2020
netil pushed a commit that referenced this issue Aug 4, 2020
@semantic-release-bot
chore(release): 2.1.0-next.1 [skip ci]
00207ac 
# [2.1.0-next.1](2.0.1...2.1.0-next.1) (2020-08-04)

### Bug Fixes

* **arc:** wrong right padding calculation ([f5a8602](f5a8602)), closes [#1545](#1545)
* **area:** Fix dynamic area loading ([9d6e1e0](9d6e1e0)), closes [#1547](#1547)
* **axis:** fix y axis clip-path coordinates ([bdf7694](bdf7694)), closes [#1572](#1572)
* **types:** Specify context for callbacks ([f3b9f26](f3b9f26)), closes [#1551](#1551)

### Features

* **area:** Intent to ship area.front ([fe315dc](fe315dc)), closes [#1543](#1543)
* **axis:** Improve log scale to handle 0 ([ca6cf62](ca6cf62)), closes [#1578](#1578)
* **axis:** Intent to ship axis.y2.type ([a94c25e](a94c25e)), closes [#1575](#1575)
netil added a commit that referenced this issue Aug 7, 2020
@netil
fix(axis): fix y axis clip-path coordinates
da717b8 
- Fix wrong y attribute value when axis is rotated
- Fix wrong interface name for y/y2 definition file

Fix #1572
netil pushed a commit that referenced this issue Aug 7, 2020
@semantic-release-bot
chore(release): 2.0.3 [skip ci]
9808dad 
## [2.0.3](2.0.2...2.0.3) (2020-08-07)

### Bug Fixes

* **axis:** fix y axis clip-path coordinates ([da717b8](da717b8)), closes [#1572](#1572)
* **types:** Specify context for callbacks ([574bfea](574bfea)), closes [#1551](#1551)
netil pushed a commit that referenced this issue Sep 25, 2020
@semantic-release-bot
chore(release): 2.1.0 [skip ci]
ad35057 
# [2.1.0](2.0.3...2.1.0) (2020-09-25)

### Bug Fixes

* **api:** prevent TypeError when chart already destroyed ([ce42768](ce42768)), closes [#1613](#1613)
* **axis:** fix y axis clip-path coordinates ([bdf7694](bdf7694)), closes [#1572](#1572)
* **bar:** Fix not firing data.onclick ([62e7a10](62e7a10)), closes [#1619](#1619) [#1620](#1620)
* **bar:** fix on bar tooglip grouped false ([4bd69be](4bd69be)), closes [/github.com//issues/1663#issuecomment-690991679](https://github.com//github.com/naver/billboard.js/issues/1663/issues/issuecomment-690991679)
* **grid:** Fix grid text position update ([056b565](056b565)), closes [#1592](#1592)
* **interaction:** bind touch event only for rect element ([12da3e4](12da3e4)), closes [#1650](#1650)
* upgrade d3-ease from 1.0.6 to 1.0.7 ([#1617](#1617)) ([4f78533](4f78533))
* **interaction:** correct draggable selection functionality ([160f873](160f873)), closes [#1642](#1642)
* upgrade d3-brush from 1.1.5 to 1.1.6 ([#1605](#1605)) ([624f044](624f044))
* **interaction:** fix for data point click on mobile ([727c26f](727c26f)), closes [#1651](#1651)
* **interaction:** fix retrieving event rect position ([6fc449e](6fc449e)), closes [#1670](#1670)
* **legend:** Fix error for color.threshold option ([6e06629](6e06629)), closes [#1604](#1604) [#1611](#1611)
* **legend:** Make legend blurry after click ([319d608](319d608)), closes [#1599](#1599)
* **shape:** fix possible condition removal by transpiler ([781fb61](781fb61)), closes [#1663](#1663)
* **step:** Fix rendering nullish data ([dbe7b9b](dbe7b9b)), closes [#1637](#1637)
* **types:** Fix donut option types ([1917169](1917169)), closes [#1615](#1615)
* **types:** Specify context for callbacks ([f3b9f26](f3b9f26)), closes [#1551](#1551)

### Features

* **area:** Intent to ship area.front ([fe315dc](fe315dc)), closes [#1543](#1543)
* **axis:** Improve log scale to handle 0 ([ca6cf62](ca6cf62)), closes [#1578](#1578)
* **axis:** Intent to ship axis.y2.type ([a94c25e](a94c25e)), closes [#1575](#1575)
* **interaction:** avoid multiple <rect> generation ([97df63a](97df63a)), closes [#1642](#1642)
* **plugin:** Add JS  Plugin class file ([4a20480](4a20480)), closes [#1665](#1665)
* **theme:** Add new 'datalab' theme ([aba20d4](aba20d4)), closes [#241](#241)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netil netil

Labels
bug
Projects
None yet
Milestone
Patch
Development

No branches or pull requests
1 participant
@netil