Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Area isn't rendered properly for dynamic loading #1547

Closed
netil opened this issue Jul 24, 2020 · 0 comments
Closed

Area isn't rendered properly for dynamic loading #1547

netil opened this issue Jul 24, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@netil
Copy link
Member

netil commented Jul 24, 2020

Description

Area type not showing correctly for dynamic loading using .load().

Steps to check or reproduce

var chart = bb.generate({
    bindto: "#chart",
    data: {
        columns: [
            ["data1", 30, 200, 100, 170, 150, 250],
        ],
        type: "line"
    }
});

setTimeout(() => {
  chart.load({
      columns: [
          ["data1", 100, 200, 300]
      ],
      type: "area"
  })
}, 2000);
@netil netil added the bug label Jul 24, 2020
@netil netil added this to the Patch milestone Jul 24, 2020
@netil netil self-assigned this Jul 24, 2020
netil added a commit to netil/billboard.js that referenced this issue Jul 24, 2020
Make sure to pass <g class=bb-chart-line> element for area node generation.

Ref naver#1547
@netil netil closed this as completed in 9d6e1e0 Jul 24, 2020
netil pushed a commit that referenced this issue Jul 24, 2020
## [2.0.2](2.0.1...2.0.2) (2020-07-24)

### Bug Fixes

* **arc:** wrong right padding calculation ([f5a8602](f5a8602)), closes [#1545](#1545)
* **area:** Fix dynamic area loading ([9d6e1e0](9d6e1e0)), closes [#1547](#1547)
netil pushed a commit that referenced this issue Jul 27, 2020
## [2.0.2](2.0.1...2.0.2) (2020-07-24)

### Bug Fixes

* **arc:** wrong right padding calculation ([f5a8602](f5a8602)), closes [#1545](#1545)
* **area:** Fix dynamic area loading ([9d6e1e0](9d6e1e0)), closes [#1547](#1547)
netil pushed a commit that referenced this issue Aug 4, 2020
# [2.1.0-next.1](2.0.1...2.1.0-next.1) (2020-08-04)

### Bug Fixes

* **arc:** wrong right padding calculation ([f5a8602](f5a8602)), closes [#1545](#1545)
* **area:** Fix dynamic area loading ([9d6e1e0](9d6e1e0)), closes [#1547](#1547)
* **axis:** fix y axis clip-path coordinates ([bdf7694](bdf7694)), closes [#1572](#1572)
* **types:** Specify context for callbacks ([f3b9f26](f3b9f26)), closes [#1551](#1551)

### Features

* **area:** Intent to ship area.front ([fe315dc](fe315dc)), closes [#1543](#1543)
* **axis:** Improve log scale to handle 0 ([ca6cf62](ca6cf62)), closes [#1578](#1578)
* **axis:** Intent to ship axis.y2.type ([a94c25e](a94c25e)), closes [#1575](#1575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant