feat(client): Wraps inbox prefix in an Arc
#1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
reviewed
Mar 15, 2024
thomastaylor312
force-pushed
the
feat/arc_string
branch
from
0395af9
to
78d9067
Compare
rvolosatovs
reviewed
Mar 17, 2024
The goal of the `Client` struct was to be a clonable handle. However, the struct contained a bare string that was cloned each time. In apps that clone the client regularly, this lead to quite a few allocations. This is a non-breaking change purely internal to the client Signed-off-by: Taylor Thomas <[email protected]>
thomastaylor312
force-pushed
the
feat/arc_string
branch
from
78d9067
to
8188330
Compare
rvolosatovs
approved these changes
Mar 25, 2024
Jarema
approved these changes
Mar 26, 2024
Jarema
added a commit
that referenced
this pull request
May 6, 2024
# 0.35.0 ## Overview This release makes tls setup more flexible, leveraging rusls v0.23 and allowing to pick crypto backend: * ring * aws-lc-rs * fips Some other highlights: * force reconnect via `force_reconnect` method * explicit create/update consumer API Thank you for all your contributions! ## Added * Add `ToServerAddrs` impl for array/vector of strings by @mmalek in #1231 * Add public constructor for Acker by @AbstractiveNord in #1232 * Add force reconnect by @Jarema in #1240 * Add features check by @Jarema in #1247 * Add stream placement by @Jarema in #1250 * Add consumer action by @Jarema in #1254 * Add support for aws-lc-rs (rustls v0.23.0) by @paolobarbolini in #1222 ## Fixed * Use last header value for JetStream messages by @Jarema in #1239 ## Changed * Wrap inbox prefix in an `Arc` by @thomastaylor312 in #1236 * Document feature flags by @Jarema in #1246 * Don't force flush if write buffer isn't empty by @paolobarbolini in #1241 ## New Contributors * @mmalek made their first contribution in #1231 **Full Changelog**: async-nats/v0.34.0...async-nats/v0.35.0 Signed-off-by: Tomasz Pietrek <[email protected]> Co-authored-by: Piotr Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of the
Clientstruct was to be a clonable handle. However, the struct contained a bare string that was cloned each time. In apps that clone the client regularly, this lead to quite a few allocations.This is a non-breaking change purely internal to the client