Use last header value for JetStream messages #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As republish will append new headers, using first value could lead to misleading data when a message is republish from one stream to another. This commit fixes it by always picking the last header value. Signed-off-by: Tomasz Pietrek <[email protected]>
Jarema
force-pushed
the
use-last-header-value
branch
from
ed73b60
to
bea1b3b
Compare
Jarema
added a commit
that referenced
this pull request
May 6, 2024
# 0.35.0 ## Overview This release makes tls setup more flexible, leveraging rusls v0.23 and allowing to pick crypto backend: * ring * aws-lc-rs * fips Some other highlights: * force reconnect via `force_reconnect` method * explicit create/update consumer API Thank you for all your contributions! ## Added * Add `ToServerAddrs` impl for array/vector of strings by @mmalek in #1231 * Add public constructor for Acker by @AbstractiveNord in #1232 * Add force reconnect by @Jarema in #1240 * Add features check by @Jarema in #1247 * Add stream placement by @Jarema in #1250 * Add consumer action by @Jarema in #1254 * Add support for aws-lc-rs (rustls v0.23.0) by @paolobarbolini in #1222 ## Fixed * Use last header value for JetStream messages by @Jarema in #1239 ## Changed * Wrap inbox prefix in an `Arc` by @thomastaylor312 in #1236 * Document feature flags by @Jarema in #1246 * Don't force flush if write buffer isn't empty by @paolobarbolini in #1241 ## New Contributors * @mmalek made their first contribution in #1231 **Full Changelog**: async-nats/v0.34.0...async-nats/v0.35.0 Signed-off-by: Tomasz Pietrek <[email protected]> Co-authored-by: Piotr Piotrowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As republish will append new headers, using first value could lead to misleading data when a message is republish from one stream to another.
This commit fixes it by always picking the last header value.
reference ADR issue: nats-io/nats-architecture-and-design#250
Signed-off-by: Tomasz Pietrek <[email protected]