Add error details to invalid JetStream JSON errors #5868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@ripienaar This ok to add in to existing error or should we add a new one?
|
We've done is often enough that one more won't make it worse :) If used correctly the text is designed to be changed and improved over time for user friendliness. Error checks should be done against the number essentially. |
derekcollison
deleted the
add-error-details-to-invalid-jetstream-json-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently failures to unmarshal only give a vague error of "invalid JSON", this adds the original error to it as context.
Before:
After:
Related to but not dependent on #5858
Signed-off-by: Casper Beyer [email protected]