Implement strict decoding for JetStream API requests

[caspervonb]

This implements optional strict JSON decoding for JetStream.

The intent of this is to minimize accidental misalignments between server and clients, we've had numerous of these across the various clients, especially for rarely used fields in the request payloads.

Signed-off-by: Casper Beyer [email protected]

[derekcollison]

https://app.travis-ci.com/github/nats-io/nats-server/jobs/625767923

Needs a fix

[caspervonb]

There's one failing test, but this is failing on main as-well so I don't think that's related.

[caspervonb]

Ran the meta benchmarks on this as they're pretty request heavy:

JetStreamCreate/N=1,R=1,storage=Memory,C=12/resource=Stream-14        593.6µ ± ∞ ¹   618.6µ ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=1,R=1,storage=Memory,C=12/resource=KVBucket-14      1.065m ± ∞ ¹   1.074m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=1,R=1,storage=Memory,C=12/resource=ObjStore-14      2.889m ± ∞ ¹   2.831m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=3,R=3,storage=Memory,C=12/resource=Stream-14        51.54m ± ∞ ¹   56.28m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=3,R=3,storage=Memory,C=12/resource=KVBucket-14      63.51m ± ∞ ¹   58.32m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=3,R=3,storage=Memory,C=12/resource=ObjStore-14      62.60m ± ∞ ¹   64.33m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=3,R=3,storage=File,C=12/resource=Stream-14          60.38m ± ∞ ¹   56.13m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=3,R=3,storage=File,C=12/resource=KVBucket-14        66.11m ± ∞ ¹   56.62m ± ∞ ¹       ~ (p=1.000 n=1) ²
JetStreamCreate/N=3,R=3,storage=File,C=12/resource=ObjStore-14        58.56m ± ∞ ¹   59.47m ± ∞ ¹       ~ (p=1.000 n=1) ²

[neilalexander]

Mind rebasing this & resolving conflicts please?

[ripienaar]

Please make sure the strict option value is shown in jsz output

[neilalexander]

LGTM

[derekcollison]

LGTM