-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Authorization support #38
Conversation
buf := &bytes.Buffer{} | ||
encoder := json.NewEncoder(buf) | ||
encoder.SetEscapeHTML(false) | ||
err := encoder.Encode(conf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since gnatsd
v1.1.0 is out, could wait for the Docker image to be available and remove all of this and just use JSON here (filed issue to remove: #39)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a visual pass through. I agree with the thought you mentioned in slack about waiting for the gnatsd v1.1.0 docker image for JSON support.
This is in order to rely on the new JSON support from the NATS server.
This adds support for configuring users and permissions on subjects on a
NatsCluster
. The users permissions have to be defined as aSecret
in JSON which is then included as part of the configuration of the server:Then as part of the
NatsCluster
definition, it is specified what is the secret from where the users permissions will be picked up:Fixes #1
Fixes #31