Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication support #1

Closed
pires opened this issue Dec 4, 2016 · 2 comments
Closed

Authentication support #1

pires opened this issue Dec 4, 2016 · 2 comments
Labels
Milestone

Comments

@pires
Copy link
Collaborator

pires commented Dec 4, 2016

No description provided.

@pires pires added the feature label Dec 4, 2016
@pires pires modified the milestones: 0.2.0, 0.1.0 Dec 4, 2016
@ColinSullivan1
Copy link
Member

@pires , @wallyqs - Although not explicitly tested, this issue is resolved by #26, right?

@wallyqs
Copy link
Member

wallyqs commented Mar 9, 2018

@ColinSullivan1 that is one part needed but also a few more parts pending:

  • Make it possible to parameterize the auth via the ClusterSpec here
    type ClusterSpec struct {
  • Codegen updates for the new field for Auth support
  • Include the Authorization field when present to the generated config
    sconfig := &natsconf.ServerConfig{
    Port: int(constants.ClientPort),
    HTTPPort: int(constants.MonitoringPort),
    Cluster: &natsconf.ClusterConfig{
    Port: int(constants.ClusterPort),
    Routes: routes,
    },
    }
  • Do the same for cluster config (for this we could generate password on the fly I think but for client auth it needs to be customizable somehow)
    Authorization *AuthorizationConfig `json:"authorization,omitempty"`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants