Allow Pod Template to provide initContainers, Volumes, and Containers #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `NewNatsPodSpec` would initialize it the spec from a deep copy of the PodTemplate, if it was provided by the user. However, it then overwrites initContainers, Volumes, and Containers with item lists that are build at runtime. This commit changes the behavior to append to the existing lists, enabling InitContainers, Volumes, and Containers to be specified in the pod template. Additionally, this adds a `VolumeMounts` item to the PodPolicy so that volumes provided in the template, can be mounted into the nats container.
wallyqs
approved these changes
Apr 2, 2019
|
Merged including a couple of fixes (bbff797) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
NewNatsPodSpecwould initialize it the spec from a deepcopy of the PodTemplate, if it was provided by the user. However, it then
overwrites initContainers, Volumes, and Containers with item lists that
are build at runtime.
This commit changes the behavior to append to the existing lists, enabling
InitContainers, Volumes, and Containers to be specified in the pod template.
Additionally, this adds a
VolumeMountsitem to the PodPolicy so thatvolumes provided in the template, can be mounted into the nats container.
Step #1 of addressing #156