Develop cleanup #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…munity#404) * Remove ENV_INIT_SCRIPT/init_env and source /etc/profile in lmod-setup. * Move TOPO_DIR and SFC_CLIMO_INPUT_DIR to appropriate sections. * Bug fix for orion and wcoss2 machine files. * Remove ENV_INIT from wcoss2 machine file. * Modify setting of +u/-u. * Do the same for set +e/-e * Minor modification. * Hack for gaea python3 loading.
…nce again. (ufs-community#417) * Update modulefiles/build_hera_intel and modulefiles/srw_common to allow the SRW to build and run on Hera following update to HPC-stack. * Update modulefiles/build_jet_intel and modulefiles/build_orion_intel so that NetCDF will be loaded before nccmp.
…y#411) * Deprecating CYCL_HRS Changes were made to all config files and scripts to use FIRST and LAST cycle definitions to accept the cycle HH, and frequency will start from those for all relevant computation. * Updating docs to remove ref to CYCL_HRS * Remove CYCL_HRS from workflow. * Add option to run all tests. * Fixes needed to run WE2E tests. * Fix the failed test. * Make specification of groups of test more flexible. * Addressing Mike's review comments. * Addressing Gerard's comments.
…ufs-community#412) * Only run tests on specific branches. * Removing deprecated build.yml
Happy Friday y'all!
…y#413) * Convert modulefiles to Lua. * Fix for orion build. * Fix for cheyenne, but issue with load_any remains. * Bug fix for jet data locations. * Hack for Cheyenne: Emulate load_any with try_load + isloaded combo * Fix NCO mode non-ensemble run dependency issue. * Wcoss2 bug fix thanks to @chan-hoo * Remove conda activation message from wcoss2 modulefile.
…ow.py (ufs-community#414) The error messaging in the generate_FV3LAM_wflow.py has been overhauled to be more pythonic and more user-friendly. The old bash-like print_err_msg_exit() calls are replaced with proper exception handling, and print_info_msg() calls are replaced with the use of Python's built-in logging module. The latter has the added benefit of giving the same "tee"-like functionality--where messages are printed to screen and written to a log file simultaneously--without the need for messy subprocesses and the confusing error messages that come with them. Errors are now handled in a consistent way, with the errors clearly highlighted both on screen and in the log file, as well as an easy-to-follow exception traceback for those wanting that information. In addition, several error conditions that were previously not caught at the generate step now cause the script to fail with helpful error messages. From the user perspective, functionality will not change, aside from differences when error conditions are present. Successful runs will remain the same, except that some log messaging has been clarified, and the log file contains additional information for each message, as well as some indentation changes for ease of reading.
Restore correct `conda activate` message for Cheyenne
…fs-community#430) * Remove old, deprecated "update_fork.pl" script * Move contents of test/ to tests/ to consolidate testing directories * Update tests/README.md for new path * Fixed one more new script location * Changes for CI tests from Daniel
…-community#421) * Move fixed-file mapping variables out of config_defaults. Also, move other variables that are unlikely/never changed by user. * Minor bug fix. * Use python script to check python version and packages. * Minor fixes. * Format python files with black. * Add pipefail in strict error checking mode. * Remove debugging comments from UFS_plot * More formatting changes. * Removed unused python utilities.
natalie-perlin
pushed a commit
that referenced
this pull request
Jan 23, 2024
Bring in changes from release/public-v2.2.0 to allow running on Gaea C5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update develop to head at ufs-community
Use this template to give a detailed message describing the change you want to make to the code.
You may delete any sections labeled "optional" and any instructions within .
If you are unclear on what should be written here, see https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message for some guidance and review the Code Contributor's Guide at https://github.com/ufs-community/ufs-srweather-app/wiki/Code-Manager's-Guide.
Code reviewers will assess the PR based on the criteria laid out in the Code Reviewer's Guide (https://github.com/ufs-community/ufs-srweather-app/wiki/Code-Manager's-Guide).
The title of this pull request should be a brief summary (ideally less than 100 characters) of the changes included in this PR. Please also include the branch to which this PR is being issued (e.g., "[develop]: Updated UFS_UTILS hash").
Use the "Preview" tab to see what your PR will look like when you hit "Create pull request"
--- Delete this line and those above before hitting "Create pull request" ---
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):